Skip to content

firebase packaging update #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2021
Merged

firebase packaging update #5348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/firebase/analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/analytics",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/analytics/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/analytics/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/app-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/app-check",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/app-check/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/app-check/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/app",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/app/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/app/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/auth/cordova/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/auth/cordova",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/auth/cordova/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/auth/cordova/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/auth",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/auth/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/auth/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/auth/react-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/auth/react-native",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/auth/react-native/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/auth/react-native/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/analytics",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/analytics/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/analytics/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/app-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/app-check",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/app-check/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/app-check/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/app",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "../index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "../index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/auth",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/auth/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/auth/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/database/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/database",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/database/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/database/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/firestore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/firestore",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/firestore/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/firestore/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/functions",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/functions/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/functions/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/messaging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/messaging",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/messaging/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/messaging/index.d.ts"
}
5 changes: 2 additions & 3 deletions packages/firebase/compat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "firebase/compat",
"main": "dist/index.node.cjs",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"module": "dist/index.mjs",
"react-native": "dist/index.rn.cjs.js",
"typings": "index.d.ts",
"components": [
Expand All @@ -17,6 +17,5 @@
"firestore",
"storage",
"database"
],
"type": "module"
]
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/performance/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/performance",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/performance/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/performance/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/compat/remote-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/remote-config",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/remote-config/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/remote-config/index.d.ts"
}
10 changes: 10 additions & 0 deletions packages/firebase/compat/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ const appBuilds = [
file: resolve(__dirname, 'app', appPkg.module),
format: 'es',
sourcemap: true
},
{
file: resolve(__dirname, 'app', appPkg.browser),
format: 'es',
sourcemap: true
}
],
plugins: [...plugins, typescriptPlugin],
Expand Down Expand Up @@ -140,6 +145,11 @@ const componentBuilds = compatPkg.components
file: resolve(__dirname, component, pkg.module),
format: 'es',
sourcemap: true
},
{
file: resolve(__dirname, component, pkg.browser),
format: 'es',
sourcemap: true
}
],
plugins: [...plugins, typescriptPlugin],
Expand Down
7 changes: 3 additions & 4 deletions packages/firebase/compat/storage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/compat/storage",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/compat/storage/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/compat/storage/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/database/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/database",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/database/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/database/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/firestore/lite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/firestore/lite",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/firestore/lite/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/firestore/lite/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/firestore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/firestore",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/firestore/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/firestore/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/functions",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/functions/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/functions/index.d.ts"
}
10 changes: 6 additions & 4 deletions packages/firebase/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,23 @@
*/

var gulp = require('gulp');
var concat = require('gulp-concat');
var sourcemaps = require('gulp-sourcemaps');
const replace = require('gulp-replace');

const OUTPUT_FILE = 'firebase.js';
const pkgJson = require('./package.json');
const files = pkgJson.components.map(component => {
const componentName = component.replace('/', '-');
return `firebase-${componentName}.js`;
});
const FIREBASE_APP_URL = `https://www.gstatic.com/firebasejs/${pkgJson.version}/firebase-app.js`;

gulp.task('firebase-js', function () {
gulp.task('cdn-type-module-path', function () {
return gulp
.src(files)
.pipe(sourcemaps.init({ loadMaps: true }))
.pipe(concat(OUTPUT_FILE))
// gulp-replace doesn't work with gulp-sourcemaps, so no change is made to the existing sourcemap.
// Therefore the sourcemap become slightly inaccurate
.pipe(replace('@firebase/app', FIREBASE_APP_URL))
.pipe(sourcemaps.write('.'))
.pipe(gulp.dest('.'));
});
7 changes: 3 additions & 4 deletions packages/firebase/messaging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/messaging",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/messaging/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/messaging/index.d.ts"
}
7 changes: 3 additions & 4 deletions packages/firebase/messaging/sw/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"name": "firebase/messaging/sw",
"main": "dist/index.cjs",
"main": "dist/index.cjs.js",
"browser": "dist/index.esm.js",
"module": "dist/index.esm.js",
"typings": "dist/messaging/sw/index.d.ts",
"type": "module"
"module": "dist/index.mjs",
"typings": "dist/messaging/sw/index.d.ts"
}
Loading