Skip to content

Allow publishing from any branch #5335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Allow publishing from any branch #5335

merged 2 commits into from
Sep 13, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Aug 20, 2021

This works in tandem with a change to the internal release-cli script (that branch is currently named custombranch).

The change to that script is, if publishing from master, the release branch is named release. If publishing from any other branch, the release branch is named [branch name]-releasebranch. I was going to make the suffix -release but I did a search and it's not uncommon to end dev branches with -release if we're working on the release process. So trying to make something more unique.

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2021

⚠️ No Changeset found

Latest commit: e58a180

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 20, 2021

Binary Size Report

Affected SDKs

No changes between base commit (4d747b1) and head commit (b68cb8a).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 20, 2021

Size Analysis Report

Affected Products

No changes between base commit (4d747b1) and head commit (b68cb8a).


jobs:
release:
if: github.ref == 'refs/heads/release' || endsWith(github.ref, '-releasebranch')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Didn't know that GHA provides convenient util functions.

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Sep 1, 2021
@hsubox76 hsubox76 merged commit 5f8b168 into master Sep 13, 2021
@hsubox76 hsubox76 deleted the ch-custombranch branch September 13, 2021 21:13
@firebase firebase locked and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants