Storage: Do not throw for path containing ".." #5315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the only reference to ".." in the Android repo (a test), it seems we do not try to parse ".." as a parent shortcut on the client side and just pass it directly to the server. (https://github.com/firebase/firebase-android-sdk/blob/d7017614307c4497f5b91da3c59b6de2102a17b7/firebase-storage/src/test/java/com/google/firebase/storage/PathingTest.java#L162)
So we will just remove the error and the test for it, and server errors should enable developers to debug if they pass an invalid path.
Fixes #5180