Skip to content

Storage: Do not throw for path containing ".." #5315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Conversation

hsubox76
Copy link
Contributor

Based on the only reference to ".." in the Android repo (a test), it seems we do not try to parse ".." as a parent shortcut on the client side and just pass it directly to the server. (https://github.com/firebase/firebase-android-sdk/blob/d7017614307c4497f5b91da3c59b6de2102a17b7/firebase-storage/src/test/java/com/google/firebase/storage/PathingTest.java#L162)

So we will just remove the error and the test for it, and server errors should enable developers to debug if they pass an invalid path.

Fixes #5180

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2021

🦋 Changeset detected

Latest commit: a452582

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/storage Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2021

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@hsubox76 hsubox76 requested a review from egilmorez as a code owner August 17, 2021 19:52
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (d0710d5) and head commit (5b4351d) are too large (521,850 characters) to display.

Please check below links to see details from the original test log.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 17, 2021

Binary Size Report

Affected SDKs

  • @firebase/storage

    Type Base (d0710d5) Head (d13fe8d) Diff
    browser 64.2 kB 64.1 kB -82 B (-0.1%)
    esm2017 55.3 kB 55.2 kB -82 B (-0.1%)
    main 55.8 kB 55.8 kB -82 B (-0.1%)
    module 64.2 kB 64.1 kB -82 B (-0.1%)
  • @firebase/storage-exp

    Type Base (d0710d5) Head (d13fe8d) Diff
    browser 52.0 kB 51.9 kB -82 B (-0.2%)
    main 53.3 kB 53.3 kB -82 B (-0.2%)
    module 52.0 kB 51.9 kB -82 B (-0.2%)
  • firebase

    Type Base (d0710d5) Head (d13fe8d) Diff
    firebase-storage.js 45.0 kB 45.0 kB -74 B (-0.2%)
    firebase.js 896 kB 896 kB -75 B (-0.0%)

Test Logs

@hsubox76 hsubox76 merged commit fbb32e7 into master Aug 17, 2021
@hsubox76 hsubox76 deleted the ch-storage-path-2 branch August 17, 2021 21:56
@google-oss-bot google-oss-bot mentioned this pull request Aug 17, 2021
@firebase firebase locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase Error: Firebase Storage: path param cannot contain '..' (storage/invalid-argument)
3 participants