Skip to content

Refactor Auth storage test #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 15, 2018
Merged

Conversation

wti806
Copy link
Contributor

@wti806 wti806 commented Feb 22, 2018

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

} fire/${SDK_VERSION} grpc/${grpcVersion}`;
const X_GOOG_API_CLIENT_VALUE = `gl-node/${process.versions.node} fire/${
SDK_VERSION
} grpc/${grpcVersion}`;
Copy link
Contributor

@mikelehen mikelehen Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to run "yarn" to get the new version of prettier so these diffs go away.

@jshcrowthe FYI- This sort of prettier version mismatch noise keeps coming up. I wonder if it'd make sense to do a version sanity-check in the automated prepush running of prettier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikelehen Do I need to manually revert the prettier commit and push again after running yarn?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just running yarn and then doing a git push should revert the changes, since the pre-push hook will run prettier again and it should undo the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the pre-pusher reverted the previous change in the new commit. Thank you so much @mikelehen

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @mikelehen

Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. We just need to add the demo app changes. Shouldn't be launch blocking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants