-
Notifications
You must be signed in to change notification settings - Fork 927
Refactor Auth storage test #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} fire/${SDK_VERSION} grpc/${grpcVersion}`; | ||
const X_GOOG_API_CLIENT_VALUE = `gl-node/${process.versions.node} fire/${ | ||
SDK_VERSION | ||
} grpc/${grpcVersion}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably need to run "yarn" to get the new version of prettier so these diffs go away.
@jshcrowthe FYI- This sort of prettier version mismatch noise keeps coming up. I wonder if it'd make sense to do a version sanity-check in the automated prepush running of prettier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikelehen Do I need to manually revert the prettier commit and push again after running yarn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just running yarn
and then doing a git push
should revert the changes, since the pre-push hook will run prettier again and it should undo the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the pre-pusher reverted the previous change in the new commit. Thank you so much @mikelehen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @mikelehen
…into refactor_auth_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. We just need to add the demo app changes. Shouldn't be launch blocking.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.