Skip to content

Passwordless #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 15, 2018
Merged

Passwordless #529

merged 8 commits into from
Mar 15, 2018

Conversation

wti806
Copy link
Contributor

@wti806 wti806 commented Feb 21, 2018

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

added new files for passwordless signin

added licence

exported function
@wti806 wti806 requested a review from jshcrowthe as a code owner March 13, 2018 00:58
Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typing issue. Can you also add the demo app changes to test this?

@@ -266,6 +281,7 @@ export class FirebaseAuth {
email: string,
password: string
): Promise<any>;
signInWithEmailLink(email: string, emailLink: string): Promise<any>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emailLink is optional here. Change to:
signInWithEmailLink(email: string, emailLink?: string): Promise<any>;

@Splaktar
Copy link

This PR should have also updated

interface AuthCredential {
providerId: string;
}
to add the signInMethod: string; field, right?

@bojeil-google
Copy link
Contributor

Yes that is correct. Thanks for reporting this.

@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants