-
Notifications
You must be signed in to change notification settings - Fork 940
Passwordless #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passwordless #529
Conversation
added new files for passwordless signin added licence exported function
…into passwordless
…into passwordless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one typing issue. Can you also add the demo app changes to test this?
packages/auth-types/index.d.ts
Outdated
@@ -266,6 +281,7 @@ export class FirebaseAuth { | |||
email: string, | |||
password: string | |||
): Promise<any>; | |||
signInWithEmailLink(email: string, emailLink: string): Promise<any>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emailLink
is optional here. Change to:
signInWithEmailLink(email: string, emailLink?: string): Promise<any>;
This PR should have also updated firebase-js-sdk/packages/firebase/app/index.d.ts Lines 204 to 206 in d59b724
signInMethod: string; field, right?
|
Yes that is correct. Thanks for reporting this. |
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.