Skip to content

Make initializePerformance() idempotent #5278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 12, 2021
Merged

Make initializePerformance() idempotent #5278

merged 6 commits into from
Aug 12, 2021

Conversation

hsubox76
Copy link
Contributor

Making all product initialize() functions idempotent.
See #5272

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 82cf681

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 11, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (d46d84b) and head commit (f355864).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 11, 2021 •
edited
Loading

Size Analysis Report

Affected Products

  • @firebase/performance-exp

    • getPerformance

      Size Table

      TypeBase (d46d84b)Head (f355864)Diff
      size
      17.4 kB
      17.6 kB
      +214 B (+1.2%)
      size-with-ext-deps
      35.9 kB
      36.1 kB
      +214 B (+0.6%)

    • initializePerformance

      Size Table

      TypeBase (d46d84b)Head (f355864)Diff
      size
      17.5 kB
      17.8 kB
      +329 B (+1.9%)
      size-with-ext-deps
      35.9 kB
      36.5 kB
      +660 B (+1.8%)

      External Dependency Table

      ModuleBase (d46d84b)Head (f355864)Diff
      @firebase/util

      ErrorFactory
getModularInstance
isIndexedDBAvailable
validateIndexedDBOpenable


      ErrorFactory
deepEqual
getModularInstance
isIndexedDBAvailable
validateIndexedDBOpenable


      + deepEqual

    • trace

      Size Table

      TypeBase (d46d84b)Head (f355864)Diff
      size
      17.3 kB
      17.5 kB
      +214 B (+1.2%)
      size-with-ext-deps
      35.7 kB
      36.0 kB
      +214 B (+0.6%)

@hsubox76 hsubox76 force-pushed the ch-idempotent-perf branch from 4ac6af9 to a953a53 Compare August 11, 2021 22:55
Feiyang1
Feiyang1 approved these changes Aug 11, 2021
View reviewed changes
packages-exp/performance-exp/src/index.test.ts Outdated
const fakeFirebaseApp = ({
options: fakeFirebaseConfig
} as unknown) as firebase.FirebaseApp;
// const fakeFirebaseApp = ({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@hsubox76 hsubox76 force-pushed the ch-idempotent-perf branch from 2009922 to 82cf681 Compare August 11, 2021 23:43
@hsubox76 hsubox76 merged commit 12c7eed into ch-idempotent Aug 12, 2021
@hsubox76 hsubox76 deleted the ch-idempotent-perf branch August 12, 2021 21:44
@firebase firebase locked and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @Feiyang1