Skip to content

update getAuth comment to make clear that it's idempotent #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2021
Merged

update getAuth comment to make clear that it's idempotent #5255

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5578a5
update getAuth comment
Feiyang1 Aug 6, 2021
ae5fba5
Update packages-exp/auth-exp/index.ts
Feiyang1 Aug 10, 2021
375af88
empty
Feiyang1 Aug 12, 2021
d78da3c
Merge branch 'fei-getauth-dco' of https://github.com/firebase/firebas…
Feiyang1 Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages-exp/auth-exp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ export { browserPopupRedirectResolver } from './src/platform_browser/popup_redir
export { PhoneMultiFactorGenerator } from './src/platform_browser/mfa/assertions/phone';

/**
* Initializes an Auth instance with platform specific default dependencies.
* Return the existing Auth instance that is associated with the provided {@link @firebase/app#FirebaseApp}.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinthecheung can you please take a look at it when you have a moment?

* If no instance exists, initializes an Auth instance with platform specific default dependencies.
*
* @param app - The Firebase App.
*
Expand Down