Skip to content

Add back browser CJS build as ./dist/index.browser.cjs.js. #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2021
Merged

Add back browser CJS build as ./dist/index.browser.cjs.js. #5245

merged 3 commits into from
Aug 5, 2021

Conversation

yuchenshi
Copy link
Member

This adds back a browser CJS build, once removed by #5149 but still needed by Emulator UI. No changes to exports and package.json.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 979baac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/storage Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@yuchenshi yuchenshi requested a review from egilmorez as a code owner August 4, 2021 18:41
@schmidt-sebastian schmidt-sebastian removed their assignment Aug 4, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 4, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (c52eb48) and head commit (7273223).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 4, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (c52eb48) and head commit (7273223).

Feiyang1
Feiyang1 approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you still require a cjs browser build when v9 comes out?

@Feiyang1 Feiyang1 assigned yuchenshi and unassigned Feiyang1 Aug 4, 2021
@yuchenshi
Copy link
Member Author

Would you still require a cjs browser build when v9 comes out?

We haven't attempted upgrading Emulator UI to v9 and when we do we'd probably start with compat first. I'd assume we'd still need a CJS browser build though unless proven otherwise during the migration.

@yuchenshi yuchenshi merged commit 5bda08e into master Aug 5, 2021
@yuchenshi yuchenshi deleted the ys/storage-browser-cjs branch August 5, 2021 00:05
@Feiyang1
Copy link
Member

Feiyang1 commented Aug 5, 2021

Okay. We can add the build if you need it.

@google-oss-bot google-oss-bot mentioned this pull request Aug 5, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuchenshi @google-oss-bot @Feiyang1 @schmidt-sebastian