Skip to content

Version Patch for Firebase Admin #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2018
Merged

Version Patch for Firebase Admin #524

merged 2 commits into from
Feb 21, 2018

Conversation

jshcrowthe
Copy link
Contributor

Refactor the initStandalone function to optionally patch the firebase version.
Also sets the NODE_ADMIN constant to true

hiranya911
hiranya911 approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for putting this together. Any thoughts on how this can be tested?

@jshcrowthe
Copy link
Contributor Author

@hiranya911 you should be able to pull down this change and run yarn link:packages this will set up a link to all the packages.

You can then go to your firebase-admin dev env and run yarn link @firebase/database and that should let you test locally.

@jshcrowthe jshcrowthe merged commit e784110 into master Feb 21, 2018
@jshcrowthe jshcrowthe deleted the admin-db-patch branch February 21, 2018 00:12
@hiranya911 hiranya911 mentioned this pull request Feb 21, 2018
Merged
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

@mikelehen mikelehen Awaiting requested review from mikelehen

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees

@hiranya911 hiranya911

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jshcrowthe @hiranya911 @google-oss-bot