fix: assertFails for storage read/write requests (#5086)

[lovelle-cardoso]

Fixes Issue 4 of #5086

Discussion

#5086

This PR makes assertFails work properly with the storage emulator.

Most storage permission errors throw errors with the message "(storage/unauthorized)", but assertFails only checks for the string "permission denied". This means that assertFails won't work properly for most storage unit tests.

This fix is a small one that just adds another check if the message contains the string "unauthorized". A better fix would be to ensure that all firebase products throw consistent error message codes when permission is denied, but this solution will at least fix this bug in the unit testing library for storage for the time being.

Testing

• Added unit test to packages/rules-unit-testing/test/database.test.ts called 'assertFails() if message contains unauthorized'

NOTE: It would be better if the rules-unit-testing library also contained tests for real-world usage (like actually spinning up the emulators and checking assertFails and assertSucceeds for basic actions like reading/writing from firestore, realtiime database, or storage). I think having just a few basic tests for usage would have caught this issue much quicker.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c206068

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[avolkovi]

Looks good, thanks for the fix and detailed test!