Fix transaction interference in v9 #5205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in listener unregistration, which exists in both the user facing
unsubscribe
API as well as runTransaction() (since it uses listeners internally).When we unregister a listener, we go through all existing listeners to find the one that matches. We do this by comparing the callbacks for equality.
In v8, we wrap all listeners, and hence, we have to unwrap the listener to get back to the original user function before checking for equality. Our listener looks as such:
In v9, we have:
Unfortunately, the comparison function considered all v9 listeners the same since it either compared
listener
(which only matches for the exact listener) orlistener.userCallback
(which matched every listener since the property was never set).Fixes #5195