Skip to content

[Auth] Add exported const map for error codes #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2021
Merged

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 21, 2021

Fixes #5178

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2021

⚠️ No Changeset found

Latest commit: 754a80f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2021

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 21, 2021

Binary Size Report

Affected SDKs

No changes between base commit (6ef484a) and head commit (646c6f4).

Test Logs

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Jul 21, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 21, 2021

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • AuthErrorCodes

      Size Table

      TypeBase (6ef484a)Head (646c6f4)Diff
      size
      ?
      34.1 kB
      ? (?)
      size-with-ext-deps
      ?
      45.9 kB
      ? (?)

      Dependency Table

      TypeBase (6ef484a)Head (646c6f4)Diff
      functions
      ?

      47 dependencies

      _assert
      _castAuth
      _createError
      _emulatorUrl
      _fail
      _getBrowserName
      _getClientVersion
      _getCurrentScheme
      _getFinalTarget
      _getInstance
      _getUserLanguage
      _initializeAuthInstance
      _isAndroid
      _isBlackBerry
      _isChromeIOS
      _isFirefox
      _isHttpOrHttps
      _isIEMobile
      _isOnline
      _isSafari
      _isWebOS
      _logError
      _logoutIfInvalidated
      _makeTaggedError
      _parseToken
      _performApiRequest
      _performFetchWithErrorHandling
      _persistenceKeyName
      _prodErrorMap
      _reloadWithoutSaving
      _tokenExpiresIn
      assertStringOrUndefined
      createErrorInternal
      debugAssert
      debugFail
      deleteAccount
      extractProviderData
      getAccountInfo
      getIdTokenResult
      getVersionForPlatform
      isUserInvalidated
      mergeProviderData
      registerAuth
      reload
      requestStsToken
      secondsStringToMilliseconds
      utcTimestampToDateString
      

      ?
      classes
      ?

      12 dependencies

      AuthImpl
      AuthInterop
      Delay
      FetchProvider
      InMemoryPersistence
      NetworkTimeout
      PersistenceUserManager
      ProactiveRefresh
      StsTokenManager
      Subscription
      UserImpl
      UserMetadata
      

      ?
      variables
      ?

      AuthErrorCodes
      DEFAULT_API_TIMEOUT_MS
      SERVER_ERROR_MAP
      _DEFAULT_AUTH_ERROR_FACTORY
      inMemoryPersistence
      instanceCache
      logClient
      name
      version
      

      ?
      enums
      ?
      ?

      External Dependency Table

      ModuleBase (6ef484a)Head (646c6f4)Diff
      @firebase/app-exp
      ?

      SDK_VERSION
      _registerComponent
      registerVersion
      

      ?
      @firebase/util
      ?

      ErrorFactory
      FirebaseError
      base64Decode
      createSubscribe
      getModularInstance
      getUA
      isBrowserExtension
      isMobileCordova
      isReactNative
      querystring
      

      ?
      @firebase/logger
      ?

      LogLevel
      Logger
      

      ?
      tslib
      ?

      __rest
      

      ?
      @firebase/component
      ?

      Component
      

      ?

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with a nit, thanks!

@yuchenshi yuchenshi merged commit a075b5f into master Jul 29, 2021
@yuchenshi yuchenshi deleted the sam-gc/auth-error-map branch July 29, 2021 00:12
@firebase firebase locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
doc-changes PRs that affect docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export error codes from Auth
5 participants