Skip to content

Rename all v9 modular useEmulator functions to connectEmulator #5179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2021
Merged

Rename all v9 modular useEmulator functions to connectEmulator #5179

merged 2 commits into from
Jul 21, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 20, 2021

Fixes #4930

@sam-gc sam-gc requested a review from Feiyang1 July 20, 2021 23:53
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: f7691c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 21, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (353d6e4) Head (e6f9794) Diff
    browser 296 kB 296 kB +8 B (+0.0%)
    esm2017 265 kB 265 kB +8 B (+0.0%)
    main 299 kB 299 kB +8 B (+0.0%)
    module 296 kB 296 kB +8 B (+0.0%)

  • @firebase/database-compat

    Type Base (353d6e4) Head (e6f9794) Diff
    browser 86.6 kB 86.6 kB +8 B (+0.0%)
    main 103 kB 103 kB +4 B (+0.0%)
    module 86.6 kB 86.6 kB +8 B (+0.0%)

  • @firebase/database-exp

    Type Base (353d6e4) Head (e6f9794) Diff
    browser 246 kB 246 kB +8 B (+0.0%)
    main 278 kB 278 kB +28 B (+0.0%)
    module 246 kB 246 kB +8 B (+0.0%)

  • @firebase/firestore

    Type Base (353d6e4) Head (e6f9794) Diff
    main 531 kB 531 kB +8 B (+0.0%)

  • @firebase/firestore-compat

    Type Base (353d6e4) Head (e6f9794) Diff
    browser 29.0 kB 29.0 kB +8 B (+0.0%)
    main 38.1 kB 38.1 kB +4 B (+0.0%)
    module 29.0 kB 29.0 kB +8 B (+0.0%)
    react-native 28.7 kB 28.7 kB +8 B (+0.0%)

  • @firebase/firestore-exp

    Type Base (353d6e4) Head (e6f9794) Diff
    browser 224 kB 224 kB +4 B (+0.0%)
    main 511 kB 511 kB +28 B (+0.0%)
    module 224 kB 224 kB +4 B (+0.0%)
    react-native 224 kB 224 kB +4 B (+0.0%)

  • @firebase/firestore-lite

    Type Base (353d6e4) Head (e6f9794) Diff
    browser 72.7 kB 72.7 kB +4 B (+0.0%)
    main 149 kB 149 kB +28 B (+0.0%)
    module 72.7 kB 72.7 kB +4 B (+0.0%)
    react-native 72.9 kB 72.9 kB +4 B (+0.0%)

  • @firebase/firestore/bundle

    Type Base (353d6e4) Head (e6f9794) Diff
    main 527 kB 527 kB +8 B (+0.0%)

  • @firebase/firestore/memory

    Type Base (353d6e4) Head (e6f9794) Diff
    main 325 kB 325 kB +8 B (+0.0%)

  • @firebase/firestore/memory-bundle

    Type Base (353d6e4) Head (e6f9794) Diff
    main 322 kB 322 kB +8 B (+0.0%)

  • @firebase/storage

    Type Base (353d6e4) Head (e6f9794) Diff
    browser 63.7 kB 63.7 kB +8 B (+0.0%)
    esm2017 54.9 kB 54.9 kB +8 B (+0.0%)
    main 55.4 kB 55.4 kB +8 B (+0.0%)
    module 63.7 kB 63.7 kB +8 B (+0.0%)

  • @firebase/storage-compat

    Type Base (353d6e4) Head (e6f9794) Diff
    browser 10.3 kB 10.3 kB +8 B (+0.1%)
    main 29.3 kB 29.3 kB +8 B (+0.0%)
    module 10.3 kB 10.3 kB +8 B (+0.1%)

  • @firebase/storage-exp

    Type Base (353d6e4) Head (e6f9794) Diff
    browser 51.6 kB 51.6 kB +16 B (+0.0%)
    main 53.0 kB 53.0 kB +36 B (+0.1%)
    module 51.6 kB 51.6 kB +16 B (+0.0%)

Test Logs

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Jul 21, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 21, 2021 •
edited
Loading

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • connectAuthEmulator

      Size Table

      TypeBase (353d6e4)Head (e6f9794)Diff
      size
      ?
      31.2 kB
      ? (?)
      size-with-ext-deps
      ?
      43.0 kB
      ? (?)

      Dependency Table

      TypeBase (353d6e4)Head (e6f9794)Diff
      functions
      ?

      <full-list-too-large-to-display>
<see-test-logs-below-for-details>

      ?
      classes
      ?

      12 dependencies

      AuthImpl
AuthInterop
Delay
FetchProvider
InMemoryPersistence
NetworkTimeout
PersistenceUserManager
ProactiveRefresh
StsTokenManager
Subscription
UserImpl
UserMetadata

      ?
      variables
      ?

      DEFAULT_API_TIMEOUT_MS
SERVER_ERROR_MAP
_DEFAULT_AUTH_ERROR_FACTORY
inMemoryPersistence
instanceCache
logClient
name
version

      ?
      enums
      ?
      ?

      External Dependency Table

      ModuleBase (353d6e4)Head (e6f9794)Diff
      @firebase/app-exp
      ?

      SDK_VERSION
_registerComponent
registerVersion

      ?
      @firebase/util
      ?

      ErrorFactory
FirebaseError
base64Decode
createSubscribe
getModularInstance
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring

      ?
      @firebase/logger
      ?

      LogLevel
Logger

      ?
      tslib
      ?

      __rest

      ?
      @firebase/component
      ?

      Component

      ?

    • debugErrorMap

      Size Table

      TypeBase (353d6e4)Head (e6f9794)Diff
      size
      40.3 kB
      40.3 kB
      +4 B (+0.0%)
      size-with-ext-deps
      52.1 kB
      52.1 kB
      +4 B (+0.0%)

  • @firebase/functions-exp

    • connectFunctionsEmulator

      Size Table

      TypeBase (353d6e4)Head (e6f9794)Diff
      size
      ?
      2.36 kB
      ? (?)
      size-with-ext-deps
      ?
      7.09 kB
      ? (?)

      Dependency Table

      TypeBase (353d6e4)Head (e6f9794)Diff
      functions
      ?

      connectFunctionsEmulator
connectFunctionsEmulator$1
registerFunctions

      ?
      classes
      ?

      ContextProvider
FunctionsService

      ?
      variables
      ?

      APP_CHECK_INTERNAL_NAME
DEFAULT_REGION
FUNCTIONS_TYPE
name
version

      ?
      enums
      ?
      ?

      External Dependency Table

      ModuleBase (353d6e4)Head (e6f9794)Diff
      @firebase/app-exp
      ?

      _registerComponent
registerVersion

      ?
      @firebase/util
      ?

      getModularInstance

      ?
      @firebase/component
      ?

      Component

      ?

@sam-gc sam-gc merged commit 6ef484a into master Jul 21, 2021
@sam-gc sam-gc deleted the sam-gc/useEmulator branch July 21, 2021 21:54
@firebase firebase locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@jsdt jsdt Awaiting requested review from jsdt

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees

@Feiyang1 Feiyang1

@egilmorez egilmorez

Labels
doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use[FIREBASEPRODUCT]Emulator conflicts with react hooks
5 participants
@sam-gc @google-oss-bot @Feiyang1 @yuchenshi @egilmorez