Skip to content

[Auth] Fix promise rejection for failing when loading JS #5145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 12, 2021

Fixes #5141
Now the promise will reject with an error instead of the result of onerror.

@sam-gc sam-gc requested a review from yuchenshi July 12, 2021 18:12
@sam-gc sam-gc requested a review from avolkovi as a code owner July 12, 2021 18:12
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2021

⚠️ No Changeset found

Latest commit: 7db1889

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2021

Binary Size Report

Affected SDKs

No changes between base commit (aeab9ce) and head commit (43a98fa).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 12, 2021

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • RecaptchaVerifier

      Size Table

      TypeBase (aeab9ce)Head (43a98fa)Diff
      size
      35.8 kB
      35.8 kB
      +51 B (+0.1%)
      size-with-ext-deps
      47.7 kB
      47.7 kB
      +52 B (+0.1%)
    • getAuth

      Size Table

      TypeBase (aeab9ce)Head (43a98fa)Diff
      size
      60.8 kB
      60.9 kB
      +51 B (+0.1%)
      size-with-ext-deps
      73.0 kB
      73.1 kB
      +52 B (+0.1%)
    • browserPopupRedirectResolver

      Size Table

      TypeBase (aeab9ce)Head (43a98fa)Diff
      size
      53.2 kB
      53.3 kB
      +51 B (+0.1%)
      size-with-ext-deps
      65.3 kB
      65.4 kB
      +52 B (+0.1%)

@sam-gc sam-gc merged commit cca8d4b into master Jul 14, 2021
@sam-gc sam-gc deleted the sam-gc/promise-error branch July 14, 2021 17:40
@firebase firebase locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non error object is passed to Promise.reject
4 participants