Skip to content

Add cordova and react-native entry points to firebase/auth #5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Jul 9, 2021

Addresses #5068

@Feiyang1 Feiyang1 added the v9 label Jul 9, 2021
@Feiyang1 Feiyang1 added this to the v9 GA milestone Jul 9, 2021
@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2021

⚠️ No Changeset found

Latest commit: d00653a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 9, 2021

Binary Size Report

Affected SDKs

No changes between base commit (2a2a376) and head commit (e73b31a).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 9, 2021

Size Analysis Report

Affected Products

No changes between base commit (2a2a376) and head commit (e73b31a).

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned sam-gc Jul 9, 2021
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some package.json seems to be out of sync and has an old version of the rollup dep, causing the yarn.lock changes here. I don't see anything in this PR's files so it might be out of scope of this PR but I think you should probably at least not add yarn.lock to this PR.

@Feiyang1 Feiyang1 merged commit 6564e99 into master Jul 9, 2021
@Feiyang1 Feiyang1 deleted the fei-auth-entrypoints branch July 9, 2021 22:14
@firebase firebase locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants