Add debug token caching to app-check-exp #5110

hsubox76 · 2021-07-02T17:35:26Z

Ported from v8: #5055
Also includes some of the test reliability fixes in 5055 that I missed porting over in an earlier PR.

changeset-bot · 2021-07-02T17:35:28Z

⚠️ No Changeset found

Latest commit: b1e2a67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2021-07-02T17:38:17Z

Changeset File Check ⚠️

Changeset formatting error in following file:

Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

google-oss-bot · 2021-07-02T18:01:56Z

Binary Size Report

Affected SDKs

@firebase/app-check

Type Base (3827d96) Head (d68213f) Diff

browser 22.5 kB 22.5 kB -7 B (-0.0%)

esm2017 18.7 kB 18.7 kB -7 B (-0.0%)

main 22.5 kB 22.5 kB -7 B (-0.0%)

module 22.1 kB 22.1 kB -7 B (-0.0%)
@firebase/database

Type Base (3827d96) Head (d68213f) Diff

browser 296 kB 296 kB +10 B (+0.0%)

esm2017 265 kB 265 kB +10 B (+0.0%)

main 299 kB 299 kB +10 B (+0.0%)

module 296 kB 296 kB +10 B (+0.0%)
@firebase/database-compat

Type Base (3827d96) Head (d68213f) Diff

browser 86.5 kB 86.5 kB +10 B (+0.0%)

main 103 kB 103 kB +10 B (+0.0%)

module 86.5 kB 86.5 kB +10 B (+0.0%)
@firebase/database-exp

Type Base (3827d96) Head (d68213f) Diff

browser 246 kB 246 kB +10 B (+0.0%)

main 278 kB 278 kB +10 B (+0.0%)

module 246 kB 246 kB +10 B (+0.0%)
firebase

Type Base (3827d96) Head (d68213f) Diff

firebase-app-check.js 22.8 kB 22.8 kB -4 B (-0.0%)

firebase.js 893 kB 893 kB -4 B (-0.0%)

Test Logs

Base (3827d969): https://github.com/firebase/firebase-js-sdk/actions/runs/994184726
Head (d68213f2): https://github.com/firebase/firebase-js-sdk/actions/runs/1024230438

google-oss-bot · 2021-07-02T18:10:04Z

Size Analysis Report

Affected Products

@firebase/app-check-exp
- CustomProvider
  Size Table
  Type Base (3827d96) Head (d68213f) Diff
  size
  9.81 kB
  9.83 kB
  +23 B (+0.2%)
  size-with-ext-deps
  19.6 kB
  19.6 kB
  +25 B (+0.1%)
- ReCaptchaV3Provider
  Size Table
  Type Base (3827d96) Head (d68213f) Diff
  size
  11.1 kB
  11.1 kB
  +24 B (+0.2%)
  size-with-ext-deps
  20.5 kB
  20.5 kB
  +25 B (+0.1%)
- getToken
  Size Table
  Type Base (3827d96) Head (d68213f) Diff
  size
  9.52 kB
  9.54 kB
  +23 B (+0.2%)
  size-with-ext-deps
  18.9 kB
  18.9 kB
  +25 B (+0.1%)
- initializeAppCheck
  Size Table
  Type Base (3827d96) Head (d68213f) Diff
  size
  9.93 kB
  9.96 kB
  +23 B (+0.2%)
  size-with-ext-deps
  19.5 kB
  19.5 kB
  +25 B (+0.1%)
- onTokenChanged
  Size Table
  Type Base (3827d96) Head (d68213f) Diff
  size
  9.61 kB
  9.64 kB
  +23 B (+0.2%)
  size-with-ext-deps
  19.0 kB
  19.0 kB
  +25 B (+0.1%)
- setTokenAutoRefreshEnabled
  Size Table
  Type Base (3827d96) Head (d68213f) Diff
  size
  9.65 kB
  9.67 kB
  +23 B (+0.2%)
  size-with-ext-deps
  19.0 kB
  19.0 kB
  +25 B (+0.1%)
@firebase/auth-exp
- getAuth
  Size Table
  Type Base (3827d96) Head (d68213f) Diff
  size
  60.8 kB
  60.8 kB
  +4 B (+0.0%)
  size-with-ext-deps
  73.0 kB
  73.0 kB
  +4 B (+0.0%)
- browserPopupRedirectResolver
  Size Table
  Type Base (3827d96) Head (d68213f) Diff
  size
  53.2 kB
  53.2 kB
  +4 B (+0.0%)
  size-with-ext-deps
  65.3 kB
  65.3 kB
  +4 B (+0.0%)

Test Logs

Feiyang1 · 2021-07-07T22:32:28Z

packages-exp/app-check-exp/src/internal-api.test.ts

@@ -239,6 +236,7 @@ describe('internal api', () => {
    });

    it('ignores listeners that throw', async () => {
+      stub(console, 'error');


Is it to just suppress error messages during testing? If so, can you please add comments to clarify?

packages-exp/app-check-exp/src/internal-api.ts

Co-authored-by: Feiyang <[email protected]>

Add debug token caching to app-check-exp

a97b231

hsubox76 requested review from Feiyang1 and hiranya911 as code owners July 2, 2021 17:35

hsubox76 added this to the v9 GA milestone Jul 2, 2021

hsubox76 assigned Feiyang1 Jul 7, 2021

Feiyang1 reviewed Jul 7, 2021

View reviewed changes

Feiyang1 assigned hsubox76 and unassigned Feiyang1 Jul 7, 2021

Address PR comments

9187e31

hsubox76 assigned Feiyang1 and unassigned hsubox76 Jul 9, 2021

Feiyang1 assigned hsubox76 and unassigned Feiyang1 Jul 12, 2021

Update packages-exp/app-check-exp/src/internal-api.ts

b1e2a67

Co-authored-by: Feiyang <[email protected]>

hsubox76 assigned Feiyang1 and unassigned hsubox76 Jul 12, 2021

Feiyang1 approved these changes Jul 12, 2021

View reviewed changes

Feiyang1 assigned hsubox76 and unassigned Feiyang1 Jul 12, 2021

hsubox76 merged commit 3550d4e into master Jul 13, 2021

hsubox76 deleted the ch-acexp-debug branch July 13, 2021 17:25

firebase locked and limited conversation to collaborators Aug 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add debug token caching to app-check-exp #5110

Add debug token caching to app-check-exp #5110

hsubox76 commented Jul 2, 2021

changeset-bot bot commented Jul 2, 2021 •

edited

Loading

github-actions bot commented Jul 2, 2021 •

edited

Loading

google-oss-bot commented Jul 2, 2021 •

edited

Loading

`@firebase/app-check`

`@firebase/database`

`@firebase/database-compat`

`@firebase/database-exp`

`firebase`

google-oss-bot commented Jul 2, 2021 •

edited

Loading

Affected Products

`@firebase/app-check-exp`

`CustomProvider`

`ReCaptchaV3Provider`

`getToken`

`initializeAppCheck`

`onTokenChanged`

`setTokenAutoRefreshEnabled`

`@firebase/auth-exp`

`getAuth`

`browserPopupRedirectResolver`

Test Logs

Feiyang1 Jul 7, 2021

hsubox76 Jul 9, 2021

Add debug token caching to app-check-exp #5110

Add debug token caching to app-check-exp #5110

Conversation

hsubox76 commented Jul 2, 2021

changeset-bot bot commented Jul 2, 2021 • edited Loading

⚠️ No Changeset found

github-actions bot commented Jul 2, 2021 • edited Loading

Changeset File Check ⚠️

google-oss-bot commented Jul 2, 2021 • edited Loading

Binary Size Report

Affected SDKs

@firebase/app-check

@firebase/database

@firebase/database-compat

@firebase/database-exp

firebase

Test Logs

google-oss-bot commented Jul 2, 2021 • edited Loading

Size Analysis Report

Affected Products

@firebase/app-check-exp

CustomProvider

ReCaptchaV3Provider

getToken

initializeAppCheck

onTokenChanged

setTokenAutoRefreshEnabled

@firebase/auth-exp

getAuth

browserPopupRedirectResolver

Test Logs

Feiyang1 Jul 7, 2021

Choose a reason for hiding this comment

hsubox76 Jul 9, 2021

Choose a reason for hiding this comment

changeset-bot bot commented Jul 2, 2021 •

edited

Loading

github-actions bot commented Jul 2, 2021 •

edited

Loading

google-oss-bot commented Jul 2, 2021 •

edited

Loading

`@firebase/app-check`

`@firebase/database`

`@firebase/database-compat`

`@firebase/database-exp`

`firebase`

google-oss-bot commented Jul 2, 2021 •

edited

Loading

`@firebase/app-check-exp`

`CustomProvider`

`ReCaptchaV3Provider`

`getToken`

`initializeAppCheck`

`onTokenChanged`

`setTokenAutoRefreshEnabled`

`@firebase/auth-exp`

`getAuth`

`browserPopupRedirectResolver`