Skip to content

Standardize transaction retries to attempts #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2021
Merged

Standardize transaction retries to attempts #5075

merged 1 commit into from
Jun 29, 2021

Conversation

thebrianchen
Copy link

Porting from Android

@thebrianchen thebrianchen self-assigned this Jun 28, 2021
@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2021

⚠️ No Changeset found

Latest commit: 8582984

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thebrianchen thebrianchen changed the title rename retries to attempts Standardize transaction retries to attempts Jun 28, 2021
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (1e6bd3e) and head commit (f55554a).

schmidt-sebastian
schmidt-sebastian reviewed Jun 29, 2021
View reviewed changes
packages/firestore/test/integration/util/internal_helpers.ts
@@ -49,7 +49,8 @@ export function getDefaultDatabaseInfo(): DatabaseInfo {
DEFAULT_SETTINGS.host!,
!!DEFAULT_SETTINGS.ssl,
!!DEFAULT_SETTINGS.experimentalForceLongPolling,
!!DEFAULT_SETTINGS.experimentalAutoDetectLongPolling
!!DEFAULT_SETTINGS.experimentalAutoDetectLongPolling,
/*use FetchStreams= */ false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whee

@thebrianchen thebrianchen merged commit 74ed43d into master Jun 29, 2021
@thebrianchen thebrianchen deleted the bc/tx-attempts branch June 29, 2021 22:40
@firebase firebase locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebrianchen @google-oss-bot @schmidt-sebastian