Skip to content

[Auth] Fix Firefox Indexed DB workaround issue for v9. Update test to workaround same issue in v8 #5062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2021
Merged

[Auth] Fix Firefox Indexed DB workaround issue for v9. Update test to workaround same issue in v8 #5062

merged 4 commits into from
Jun 23, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jun 23, 2021

No description provided.

@sam-gc sam-gc requested a review from yuchenshi June 23, 2021 18:27
@sam-gc sam-gc requested a review from avolkovi as a code owner June 23, 2021 18:27
@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 72788dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (a5c2974) and head commit (6e20398).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2021 •
edited
Loading

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • getAuth

      Size Table

      TypeBase (a5c2974)Head (a3ff946)Diff
      size
      55.5 kB
      55.5 kB
      +12 B (+0.0%)
      size-with-ext-deps
      67.5 kB
      67.6 kB
      +12 B (+0.0%)

    • indexedDBLocalPersistence

      Size Table

      TypeBase (a5c2974)Head (a3ff946)Diff
      size
      36.8 kB
      36.8 kB
      +12 B (+0.0%)
      size-with-ext-deps
      48.0 kB
      48.1 kB
      +12 B (+0.0%)

@sam-gc sam-gc merged commit d9dc89f into master Jun 23, 2021
@sam-gc sam-gc deleted the sam-gc/idb-fix branch June 23, 2021 19:07
@firebase firebase locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi