Skip to content

Pass the instance to onInit callback #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2021
Merged

Pass the instance to onInit callback #5023

merged 3 commits into from
Jun 15, 2021

Conversation

Feiyang1
Copy link
Member

Fixes #5018

@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 80bef4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@firebase/component Patch
@firebase/analytics Patch
@firebase/app-check Patch
@firebase/app Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/rules-unit-testing Patch
@firebase/storage Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Feiyang1 Feiyang1 requested a review from egilmorez as a code owner June 14, 2021 19:11
@Feiyang1
Copy link
Member Author

@schmidt-sebastian FYI

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 14, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (175070c) Head (29c674d) Diff
    esm2017 ? 18.7 kB ? (?)
    main ? 24.2 kB ? (?)
    module ? 23.4 kB ? (?)

  • @firebase/api-documenter

    Type Base (175070c) Head (29c674d) Diff
    main ? 3.72 kB ? (?)

  • @firebase/app

    Type Base (175070c) Head (29c674d) Diff
    browser ? 11.0 kB ? (?)
    esm2017 ? 9.81 kB ? (?)
    lite ? 8.95 kB ? (?)
    lite-esm2017 ? 7.93 kB ? (?)
    main ? 10.2 kB ? (?)
    module ? 11.0 kB ? (?)
    react-native ? 9.87 kB ? (?)

  • @firebase/app-check

    Type Base (175070c) Head (29c674d) Diff
    browser ? 20.9 kB ? (?)
    esm2017 ? 17.3 kB ? (?)
    main ? 20.9 kB ? (?)
    module ? 20.5 kB ? (?)

  • @firebase/auth

    Type Base (175070c) Head (29c674d) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)

  • @firebase/component

    Type Base (175070c) Head (29c674d) Diff
    browser ? 8.33 kB ? (?)
    esm2017 ? 6.32 kB ? (?)
    main ? 8.67 kB ? (?)
    module ? 8.33 kB ? (?)

  • @firebase/database

    Type Base (175070c) Head (29c674d) Diff
    browser ? 296 kB ? (?)
    esm2017 ? 265 kB ? (?)
    main ? 299 kB ? (?)
    module ? 296 kB ? (?)

  • @firebase/database-compat

    Type Base (175070c) Head (29c674d) Diff
    browser ? 86.5 kB ? (?)
    main ? 103 kB ? (?)
    module ? 86.5 kB ? (?)

  • @firebase/database-exp

    Type Base (175070c) Head (29c674d) Diff
    browser ? 246 kB ? (?)
    main ? 278 kB ? (?)
    module ? 246 kB ? (?)

  • @firebase/firestore

    Type Base (175070c) Head (29c674d) Diff
    browser ? 284 kB ? (?)
    esm2017 ? 226 kB ? (?)
    main ? 531 kB ? (?)
    module ? 284 kB ? (?)
    react-native ? 227 kB ? (?)

  • @firebase/firestore-compat

    Type Base (175070c) Head (29c674d) Diff
    browser ? 28.9 kB ? (?)
    main ? 38.1 kB ? (?)
    module ? 28.9 kB ? (?)
    react-native ? 28.7 kB ? (?)

  • @firebase/firestore-exp

    Type Base (175070c) Head (29c674d) Diff
    browser ? 224 kB ? (?)
    main ? 510 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 224 kB ? (?)

  • @firebase/firestore-lite

    Type Base (175070c) Head (29c674d) Diff
    browser ? 72.5 kB ? (?)
    main ? 149 kB ? (?)
    module ? 72.5 kB ? (?)
    react-native ? 72.7 kB ? (?)

  • @firebase/firestore/bundle

    Type Base (175070c) Head (29c674d) Diff
    browser ? 290 kB ? (?)
    esm2017 ? 177 kB ? (?)
    main ? 527 kB ? (?)
    module ? 290 kB ? (?)
    react-native ? 177 kB ? (?)

  • @firebase/firestore/memory

    Type Base (175070c) Head (29c674d) Diff
    browser ? 216 kB ? (?)
    esm2017 ? 172 kB ? (?)
    main ? 325 kB ? (?)
    module ? 216 kB ? (?)
    react-native ? 172 kB ? (?)

  • @firebase/firestore/memory-bundle

    Type Base (175070c) Head (29c674d) Diff
    browser ? 224 kB ? (?)
    esm2017 ? 177 kB ? (?)
    main ? 322 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 177 kB ? (?)

  • @firebase/functions

    Type Base (175070c) Head (29c674d) Diff
    browser ? 10.7 kB ? (?)
    esm2017 ? 8.21 kB ? (?)
    main ? 11.1 kB ? (?)
    module ? 10.7 kB ? (?)

  • @firebase/installations

    Type Base (175070c) Head (29c674d) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.2 kB ? (?)
    module ? 21.6 kB ? (?)

  • @firebase/logger

    Type Base (175070c) Head (29c674d) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.38 kB ? (?)
    module ? 4.65 kB ? (?)

  • @firebase/messaging

    Type Base (175070c) Head (29c674d) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)

  • @firebase/performance

    Type Base (175070c) Head (29c674d) Diff
    browser ? 27.7 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 27.7 kB ? (?)

  • @firebase/polyfill

    Type Base (175070c) Head (29c674d) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)

  • @firebase/remote-config

    Type Base (175070c) Head (29c674d) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.0 kB ? (?)
    module ? 22.4 kB ? (?)

  • @firebase/rules-unit-testing

    Type Base (175070c) Head (29c674d) Diff
    main ? 14.8 kB ? (?)

  • @firebase/storage

    Type Base (175070c) Head (29c674d) Diff
    browser ? 63.4 kB ? (?)
    esm2017 ? 54.6 kB ? (?)
    main ? 63.8 kB ? (?)
    module ? 63.4 kB ? (?)

  • @firebase/storage-compat

    Type Base (175070c) Head (29c674d) Diff
    browser ? 10.2 kB ? (?)
    main ? 29.1 kB ? (?)
    module ? 10.2 kB ? (?)

  • @firebase/storage-exp

    Type Base (175070c) Head (29c674d) Diff
    browser ? 51.5 kB ? (?)
    main ? 52.6 kB ? (?)
    module ? 51.5 kB ? (?)

  • @firebase/util

    Type Base (175070c) Head (29c674d) Diff
    browser ? 21.2 kB ? (?)
    esm2017 ? 20.0 kB ? (?)
    main ? 25.8 kB ? (?)
    module ? 21.2 kB ? (?)

  • @firebase/webchannel-wrapper

    Type Base (175070c) Head (29c674d) Diff
    esm2017 ? 42.2 kB ? (?)
    main ? 49.6 kB ? (?)
    module ? 43.5 kB ? (?)

  • firebase

    Click to show 16 binary size changes.
    Type Base (175070c) Head (29c674d) Diff
    firebase-analytics.js ? 35.7 kB ? (?)
    firebase-app-check.js ? 22.2 kB ? (?)
    firebase-app.js ? 21.9 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 187 kB ? (?)
    firebase-firestore.js ? 335 kB ? (?)
    firebase-firestore.memory.js ? 270 kB ? (?)
    firebase-functions.js ? 10.9 kB ? (?)
    firebase-installations.js ? 19.3 kB ? (?)
    firebase-messaging.js ? 40.9 kB ? (?)
    firebase-performance-standalone.es2017.js ? 73.4 kB ? (?)
    firebase-performance-standalone.js ? 49.8 kB ? (?)
    firebase-performance.js ? 38.3 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 41.5 kB ? (?)
    firebase.js ? 891 kB ? (?)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 14, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (175070c) and head commit (29c674d).

schmidt-sebastian
schmidt-sebastian approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad panda.

@schmidt-sebastian schmidt-sebastian mentioned this pull request Jun 15, 2021
Closed
@Feiyang1 Feiyang1 merged commit 725ab46 into master Jun 15, 2021
@Feiyang1 Feiyang1 deleted the fei-component-fix branch June 15, 2021 23:56
@google-oss-bot google-oss-bot mentioned this pull request Jun 16, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: e.auth.addAuthTokenListener is not a function
4 participants
@Feiyang1 @google-oss-bot @hsubox76 @schmidt-sebastian