Skip to content

[Auth] Make anonymous sign in wait for auth to finish initializing #4963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jun 1, 2021

This fixes b/189879344

@sam-gc sam-gc requested a review from Feiyang1 June 1, 2021 23:17
@sam-gc sam-gc requested review from avolkovi and yuchenshi as code owners June 1, 2021 23:17
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2021

⚠️ No Changeset found

Latest commit: 7af65ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (fad44a5) and head commit (17834c9).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • signInAnonymously

      Size Table

      TypeBase (fad44a5)Head (17834c9)Diff
      size
      30.7 kB
      30.7 kB
      +31 B (+0.1%)
      size-with-ext-deps
      41.9 kB
      42.0 kB
      +31 B (+0.1%)

Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! my test project have thousands of anonymous user because of it.

@Feiyang1 Feiyang1 assigned sam-gc and unassigned Feiyang1 Jun 3, 2021
@sam-gc sam-gc merged commit b046a61 into master Jun 3, 2021
@sam-gc sam-gc deleted the sam-gc/anon branch June 3, 2021 17:02
@firebase firebase locked and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants