Skip to content

Always release @firebase/app #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Always release @firebase/app #4941

merged 1 commit into from
Jun 1, 2021

Conversation

Feiyang1
Copy link
Member

Fixes #4235.

This is a complete fix by publishing @firebase/app in every release. It's a better solution than #4283 because it also works if people use scoped packages directly.

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2021

⚠️ No Changeset found

Latest commit: 24a68a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1
Copy link
Member Author

Tested locally. Is it possible to test the GHA before merging? @hsubox76

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (b49345d) and head commit (4508db0).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (b49345d) and head commit (4508db0).

@Feiyang1 Feiyang1 merged commit 61b69aa into master Jun 1, 2021
@Feiyang1 Feiyang1 deleted the fei-app-version branch June 1, 2021 23:32
@firebase firebase locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase.SDK_VERSION stuck at 8.0.1
3 participants