Skip to content

Add warning when developer overrides host without specifying merge #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2021
Merged

Add warning when developer overrides host without specifying merge #4925

merged 2 commits into from
May 20, 2021

Conversation

thebrianchen
Copy link

No description provided.

@thebrianchen thebrianchen self-assigned this May 19, 2021
@changeset-bot
Copy link

changeset-bot bot commented May 19, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: e92d844

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 19, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (997040a) Head (36154cc) Diff
    browser 284 kB 284 kB +149 B (+0.1%)
    esm2017 226 kB 226 kB +147 B (+0.1%)
    main 531 kB 531 kB +228 B (+0.0%)
    module 284 kB 284 kB +149 B (+0.1%)
    react-native 226 kB 226 kB +147 B (+0.1%)

  • @firebase/firestore-compat

    Type Base (997040a) Head (36154cc) Diff
    browser 28.6 kB 28.9 kB +391 B (+1.4%)
    main 37.6 kB 38.1 kB +496 B (+1.3%)
    module 28.6 kB 28.9 kB +391 B (+1.4%)
    react-native 28.3 kB 28.7 kB +391 B (+1.4%)

  • @firebase/firestore/bundle

    Type Base (997040a) Head (36154cc) Diff
    browser 290 kB 290 kB +145 B (+0.1%)
    esm2017 176 kB 176 kB +147 B (+0.1%)
    main 527 kB 527 kB +228 B (+0.0%)
    module 290 kB 290 kB +145 B (+0.1%)
    react-native 176 kB 176 kB +147 B (+0.1%)

  • @firebase/firestore/memory

    Type Base (997040a) Head (36154cc) Diff
    browser 216 kB 216 kB +145 B (+0.1%)
    esm2017 172 kB 172 kB +147 B (+0.1%)
    main 325 kB 325 kB +230 B (+0.1%)
    module 216 kB 216 kB +145 B (+0.1%)
    react-native 172 kB 172 kB +147 B (+0.1%)

  • @firebase/firestore/memory-bundle

    Type Base (997040a) Head (36154cc) Diff
    browser 224 kB 224 kB +145 B (+0.1%)
    esm2017 176 kB 176 kB +147 B (+0.1%)
    main 322 kB 322 kB +230 B (+0.1%)
    module 224 kB 224 kB +145 B (+0.1%)
    react-native 176 kB 176 kB +147 B (+0.1%)

  • firebase

    Type Base (997040a) Head (36154cc) Diff
    firebase-firestore.js 332 kB 332 kB +146 B (+0.0%)
    firebase-firestore.memory.js 267 kB 267 kB +146 B (+0.1%)
    firebase.js 889 kB 889 kB +146 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 19, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (997040a) and head commit (36154cc).

schmidt-sebastian
schmidt-sebastian reviewed May 20, 2021
View reviewed changes
packages/firestore/src/api/database.ts Outdated
currentSettings.host !== settingsLiteral.host
) {
logWarn(
'The original host is being overridden. If you did not intend ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change to "You are overriding the original host." to make it easier for us foreigners.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

schmidt-sebastian
schmidt-sebastian approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset. Otherwise, this will not get released next week.

@schmidt-sebastian schmidt-sebastian removed their assignment May 20, 2021
@thebrianchen thebrianchen merged commit 2a6ad8c into master May 20, 2021
@thebrianchen thebrianchen deleted the bc/warn-override branch May 20, 2021 15:53
thebrianchen pushed a commit that referenced this pull request May 20, 2021
Revert "Add warning when developer overrides host without specifying …
a02c9ce 
…merge (#4925)"

This reverts commit 2a6ad8c.
@thebrianchen thebrianchen mentioned this pull request May 20, 2021
Merged
thebrianchen pushed a commit that referenced this pull request May 20, 2021
Add changeset for #4925 (#4929)
1691745
@firebase firebase locked and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebrianchen @google-oss-bot @schmidt-sebastian