Skip to content

Function awaits messaging#getToken internally #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2021
Merged

Function awaits messaging#getToken internally #4919

merged 2 commits into from
May 18, 2021

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented May 17, 2021 •
edited
Loading

#4909 Kudos to sudkumar

@zwu52 zwu52 requested review from Feiyang1 and hsubox76 May 17, 2021 18:53
@zwu52 zwu52 requested a review from hiranya911 as a code owner May 17, 2021 18:53
@changeset-bot
Copy link

changeset-bot bot commented May 17, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 478cd12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 17, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (50860d7) Head (ea985ab) Diff
    esm2017 ? 18.7 kB ? (?)
    main ? 24.2 kB ? (?)
    module ? 23.4 kB ? (?)

  • @firebase/api-documenter

    Type Base (50860d7) Head (ea985ab) Diff
    main ? 3.72 kB ? (?)

  • @firebase/app

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 11.0 kB ? (?)
    esm2017 ? 9.81 kB ? (?)
    lite ? 8.95 kB ? (?)
    lite-esm2017 ? 7.93 kB ? (?)
    main ? 10.2 kB ? (?)
    module ? 11.0 kB ? (?)
    react-native ? 9.87 kB ? (?)

  • @firebase/app-check

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 20.9 kB ? (?)
    esm2017 ? 17.3 kB ? (?)
    main ? 20.9 kB ? (?)
    module ? 20.5 kB ? (?)

  • @firebase/auth

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)

  • @firebase/component

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 7.84 kB ? (?)
    esm2017 ? 5.88 kB ? (?)
    main ? 8.18 kB ? (?)
    module ? 7.84 kB ? (?)

  • @firebase/database

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 296 kB ? (?)
    esm2017 ? 265 kB ? (?)
    main ? 299 kB ? (?)
    module ? 296 kB ? (?)

  • @firebase/database-compat

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 86.5 kB ? (?)
    main ? 103 kB ? (?)
    module ? 86.5 kB ? (?)

  • @firebase/database-exp

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 246 kB ? (?)
    main ? 278 kB ? (?)
    module ? 246 kB ? (?)

  • @firebase/firestore

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 284 kB ? (?)
    esm2017 ? 226 kB ? (?)
    main ? 531 kB ? (?)
    module ? 284 kB ? (?)
    react-native ? 226 kB ? (?)

  • @firebase/firestore-compat

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 28.6 kB ? (?)
    main ? 37.6 kB ? (?)
    module ? 28.6 kB ? (?)
    react-native ? 28.3 kB ? (?)

  • @firebase/firestore-exp

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 224 kB ? (?)
    main ? 510 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 224 kB ? (?)

  • @firebase/firestore-lite

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 72.4 kB ? (?)
    main ? 149 kB ? (?)
    module ? 72.4 kB ? (?)
    react-native ? 72.6 kB ? (?)

  • @firebase/firestore/bundle

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 290 kB ? (?)
    esm2017 ? 176 kB ? (?)
    main ? 527 kB ? (?)
    module ? 290 kB ? (?)
    react-native ? 176 kB ? (?)

  • @firebase/firestore/memory

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 216 kB ? (?)
    esm2017 ? 172 kB ? (?)
    main ? 325 kB ? (?)
    module ? 216 kB ? (?)
    react-native ? 172 kB ? (?)

  • @firebase/firestore/memory-bundle

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 224 kB ? (?)
    esm2017 ? 176 kB ? (?)
    main ? 322 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 176 kB ? (?)

  • @firebase/functions

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 10.7 kB ? (?)
    esm2017 ? 8.15 kB ? (?)
    main ? 11.1 kB ? (?)
    module ? 10.7 kB ? (?)

  • @firebase/installations

    Type Base (50860d7) Head (ea985ab) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.2 kB ? (?)
    module ? 21.6 kB ? (?)

  • @firebase/logger

    Type Base (50860d7) Head (ea985ab) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.38 kB ? (?)
    module ? 4.65 kB ? (?)

  • @firebase/messaging

    Type Base (50860d7) Head (ea985ab) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)

  • @firebase/performance

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 27.7 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 27.7 kB ? (?)

  • @firebase/polyfill

    Type Base (50860d7) Head (ea985ab) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)

  • @firebase/remote-config

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.0 kB ? (?)
    module ? 22.4 kB ? (?)

  • @firebase/rules-unit-testing

    Type Base (50860d7) Head (ea985ab) Diff
    main ? 14.8 kB ? (?)

  • @firebase/storage

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 63.4 kB ? (?)
    esm2017 ? 54.6 kB ? (?)
    main ? 63.8 kB ? (?)
    module ? 63.4 kB ? (?)

  • @firebase/storage-compat

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 10.2 kB ? (?)
    main ? 29.1 kB ? (?)
    module ? 10.2 kB ? (?)

  • @firebase/storage-exp

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 51.5 kB ? (?)
    main ? 52.6 kB ? (?)
    module ? 51.5 kB ? (?)

  • @firebase/util

    Type Base (50860d7) Head (ea985ab) Diff
    browser ? 21.2 kB ? (?)
    esm2017 ? 20.0 kB ? (?)
    main ? 25.8 kB ? (?)
    module ? 21.2 kB ? (?)

  • @firebase/webchannel-wrapper

    Type Base (50860d7) Head (ea985ab) Diff
    esm2017 ? 39.5 kB ? (?)
    main ? 46.9 kB ? (?)
    module ? 40.8 kB ? (?)

  • firebase

    Click to show 16 binary size changes.
    Type Base (50860d7) Head (ea985ab) Diff
    firebase-analytics.js ? 35.8 kB ? (?)
    firebase-app-check.js ? 22.2 kB ? (?)
    firebase-app.js ? 21.8 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 187 kB ? (?)
    firebase-firestore.js ? 332 kB ? (?)
    firebase-firestore.memory.js ? 267 kB ? (?)
    firebase-functions.js ? 10.8 kB ? (?)
    firebase-installations.js ? 19.3 kB ? (?)
    firebase-messaging.js ? 41.0 kB ? (?)
    firebase-performance-standalone.es2017.js ? 73.1 kB ? (?)
    firebase-performance-standalone.js ? 49.7 kB ? (?)
    firebase-performance.js ? 38.3 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 41.6 kB ? (?)
    firebase.js ? 889 kB ? (?)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 17, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (50860d7) and head commit (53994e8).

@zwu52 zwu52 merged commit 4409c7e into master May 18, 2021
@zwu52 zwu52 deleted the fix_function_await_messaging branch May 18, 2021 16:35
@hsubox76 hsubox76 mentioned this pull request May 19, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
api: functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zwu52 @google-oss-bot @hsubox76