Skip to content

Fix useEmulators argument validation #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IchordeDionysos
Copy link
Contributor

Discussion

Fix related to #4863.

Testing

API Changes

Public API change only changes to the almost certainly expected behavior :)

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2021

🦋 Changeset detected

Latest commit: 99276c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samtstern
Copy link
Contributor

@IchordeDionysos thank you for sending this!

@yuchenshi yuchenshi merged commit b97dd4e into firebase:master May 13, 2021
@IchordeDionysos IchordeDionysos deleted the fix/rules-unite-test-use-emulator-validation branch May 14, 2021 14:50
@google-oss-bot google-oss-bot mentioned this pull request May 18, 2021
@firebase firebase locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants