Release CLI Fixes #490
Merged
Release CLI Fixes #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dd4ab71.
hiranya911
approved these changes
Feb 5, 2018
scripts/release/utils/git.js
Outdated
| await git.add('*/package.json'); | ||
| await git.commit( | ||
| releaseType === 'Staging' ? 'Publish Prerelease' : 'Publish' | ||
| await exec('git add */package.json'); |
There was a problem hiding this comment.
Revise the input args to this function. It doesn't look like releaseType is used any more.
| '--follow-tags': null, | ||
| '--no-verify': null | ||
| }); | ||
| exports.pushUpdatesToGithub = async tags => { |
There was a problem hiding this comment.
This is more of a style thing. As it is not specified by prettier I'm going to leave as is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues/deficiencies in the release CLI
--follow-tagswasn't functioning as expected