Skip to content

Enable platform logging for AppCheck #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/app-check/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
import { factory, internalFactory } from './factory';
import { initializeDebugMode } from './debug';
import { AppCheckInternalComponentName } from '@firebase/app-check-interop-types';
import { name, version } from '../package.json';

const APP_CHECK_NAME: AppCheckComponentName = 'appCheck';
const APP_CHECK_NAME_INTERNAL: AppCheckInternalComponentName =
Expand Down Expand Up @@ -55,7 +56,7 @@ function registerAppCheck(firebase: _FirebaseNamespace): void {
)
);

// TODO: register AppCheck version with firebase.registerVersion() before BETA. We don't want to report version in EAP
firebase.registerVersion(name, version);
}

registerAppCheck(firebase as _FirebaseNamespace);
Expand Down
2 changes: 2 additions & 0 deletions packages/app/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
export const DEFAULT_ENTRY_NAME = '[DEFAULT]';
import { name as appName } from '../package.json';
import { name as analyticsName } from '../../analytics/package.json';
import { name as appCheckName } from '../../app-check/package.json';
import { name as authName } from '../../auth/package.json';
import { name as databaseName } from '../../database/package.json';
import { name as functionsName } from '../../functions/package.json';
Expand All @@ -32,6 +33,7 @@ import { name as packageName } from '../../../package.json';
export const PLATFORM_LOG_STRING = {
[appName]: 'fire-core',
[analyticsName]: 'fire-analytics',
[appCheckName]: 'fire-app-check',
[authName]: 'fire-auth',
[databaseName]: 'fire-rtdb',
[functionsName]: 'fire-fn',
Expand Down