Skip to content

[Multi-Tab] Adding basic functionality for TabNotificationChannel #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 8, 2018
Merged

[Multi-Tab] Adding basic functionality for TabNotificationChannel #483

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8dbcb8e
Adding basic functionality for TabNotificationChannel
schmidt-sebastian Feb 2, 2018
c5099ff
[AUTOMATED]: Prettier Code Styling
schmidt-sebastian Feb 2, 2018
4c3fa4c
Comment cleanup
schmidt-sebastian Feb 2, 2018
1c2fa18
Test fix
schmidt-sebastian Feb 2, 2018
7cc1832
Addressing comments
schmidt-sebastian Feb 6, 2018
5532ac8
Fixing lint errors
schmidt-sebastian Feb 6, 2018
a0f4545
Changing Instance to Client
schmidt-sebastian Feb 7, 2018
ede438e
Main review cleanup
schmidt-sebastian Feb 7, 2018
0b42fc1
Merge branch 'master' into multitab-instancestate
schmidt-sebastian Feb 8, 2018
522917e
Fixing imports
schmidt-sebastian Feb 8, 2018
5542cd6
Cleaning up assertClientState
schmidt-sebastian Feb 8, 2018
c384115
[AUTOMATED]: Prettier Code Styling
schmidt-sebastian Feb 8, 2018
ccf9a6f
Renaming test file
schmidt-sebastian Feb 8, 2018
2369f55
Last round of feedback
schmidt-sebastian Feb 8, 2018
41252d4
[AUTOMATED]: Prettier Code Styling
schmidt-sebastian Feb 8, 2018
e09fa4a
Lint errors
schmidt-sebastian Feb 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading