Skip to content

Add isSupported for messaging-compat #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Add isSupported for messaging-compat #4829

merged 1 commit into from
Apr 23, 2021

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Apr 23, 2021

Sticky situation for providing legacy isSupported method with the modular SDK construct. Please let me know if there is a better way to just include and export the legacy API code in the messaging-compat. The rational for doing so is as followed:

  • Modular isSupported became async. It's not compatible w/ the legacy sync version.
  • Modular SDK has two entry points window and sw, but export isWindowSupported and isSwSupported as isSupported depends on the context. Not sure if there is a way to import isWindowSupported and isSwSupported separately from @firebase/messaging-exp to messaging-compat.

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2021

⚠️ No Changeset found

Latest commit: 025fce2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this seems reasonable since we can't introduce breaking changes in compat.

@zwu52 zwu52 merged commit fc04353 into master Apr 23, 2021
@zwu52 zwu52 deleted the compat_add_is_supported branch April 23, 2021 21:02
@firebase firebase locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants