Add isSupported
for messaging-compat
#4829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sticky situation for providing legacy
isSupported
method with the modular SDK construct. Please let me know if there is a better way to just include and export the legacy API code in themessaging-compat
. The rational for doing so is as followed:isSupported
became async. It's not compatible w/ the legacy sync version.window
andsw
, but exportisWindowSupported
andisSwSupported
asisSupported
depends on the context. Not sure if there is a way to importisWindowSupported
andisSwSupported
separately from@firebase/messaging-exp
tomessaging-compat
.