Make Converter explicit

[schmidt-sebastian]

Fixes: #4812

The current API does not retain the type of CollectionReference and Query since T is not referenced within these classes.

We also want to expose a type property on FirebaseFirestore. This is similar to the type property of FirebaseDatabase@exp and helps TypeScript tell apart instances of Firestore, FirestorLite and RTDB.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9e4d903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Binary Size Report

Affected SDKs

• @firebase/firestore

  Type	Base (191184e)	Head (92d8ae3)	Diff
  browser	283 kB	283 kB	+14 B (+0.0%)
  esm2017	225 kB	225 kB	+17 B (+0.0%)
  main	529 kB	529 kB	+14 B (+0.0%)
  module	283 kB	283 kB	+14 B (+0.0%)
  react-native	225 kB	225 kB	+17 B (+0.0%)

• @firebase/firestore-compat

  Type	Base (191184e)	Head (92d8ae3)	Diff
  browser	28.4 kB	28.4 kB	-3 B (-0.0%)
  main	37.4 kB	37.4 kB	-3 B (-0.0%)
  module	28.4 kB	28.4 kB	-3 B (-0.0%)
  react-native	28.1 kB	28.1 kB	-3 B (-0.0%)

• @firebase/firestore-exp

  Type	Base (191184e)	Head (92d8ae3)	Diff
  browser	223 kB	223 kB	+20 B (+0.0%)
  main	505 kB	505 kB	+17 B (+0.0%)
  module	223 kB	223 kB	+20 B (+0.0%)
  react-native	223 kB	223 kB	+20 B (+0.0%)

• @firebase/firestore-lite

  Type	Base (191184e)	Head (92d8ae3)	Diff
  browser	71.4 kB	71.4 kB	+2 B (+0.0%)
  main	145 kB	145 kB	-2 B (-0.0%)
  module	71.4 kB	71.4 kB	+2 B (+0.0%)
  react-native	71.6 kB	71.6 kB	+2 B (+0.0%)

• @firebase/firestore/bundle

  Type	Base (191184e)	Head (92d8ae3)	Diff
  browser	289 kB	289 kB	+14 B (+0.0%)
  esm2017	175 kB	175 kB	+17 B (+0.0%)
  main	525 kB	525 kB	+14 B (+0.0%)
  module	289 kB	289 kB	+14 B (+0.0%)
  react-native	175 kB	175 kB	+17 B (+0.0%)

• @firebase/firestore/memory

  Type	Base (191184e)	Head (92d8ae3)	Diff
  browser	215 kB	215 kB	+14 B (+0.0%)
  esm2017	171 kB	171 kB	+17 B (+0.0%)
  main	323 kB	323 kB	+13 B (+0.0%)
  module	215 kB	215 kB	+14 B (+0.0%)
  react-native	171 kB	171 kB	+17 B (+0.0%)

• @firebase/firestore/memory-bundle

  Type	Base (191184e)	Head (92d8ae3)	Diff
  browser	223 kB	223 kB	+14 B (+0.0%)
  esm2017	175 kB	175 kB	+17 B (+0.0%)
  main	320 kB	320 kB	+13 B (+0.0%)
  module	223 kB	223 kB	+14 B (+0.0%)
  react-native	175 kB	175 kB	+17 B (+0.0%)

• firebase

  Type	Base (191184e)	Head (92d8ae3)	Diff
  firebase-firestore.js	327 kB	328 kB	+14 B (+0.0%)
  firebase-firestore.memory.js	262 kB	262 kB	+14 B (+0.0%)
  firebase.js	869 kB	869 kB	+14 B (+0.0%)

Test Logs

• Base (191184eb): https://github.com/firebase/firebase-js-sdk/actions/runs/771747122
• Head (92d8ae3b): https://github.com/firebase/firebase-js-sdk/actions/runs/772048007

[thebrianchen]

optional: include the changeset file.

[schmidt-sebastian]

We don't yet use Changesets for firebase@exp. Thanks for the review