Skip to content

Expose addFrameworkForLogging. #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2021
Merged

Expose addFrameworkForLogging. #4786

merged 1 commit into from
Apr 15, 2021

Conversation

yuchenshi
Copy link
Member

API Changes

Internally approved. See go/firebase-auth-ts-sdk-log-framework (Googlers only)

Follow-ups

Please use the compat API on FirebaseUI + compat changes (and the modular API later).

@yuchenshi yuchenshi requested a review from sam-gc April 14, 2021 18:22
@yuchenshi yuchenshi requested a review from avolkovi as a code owner April 14, 2021 18:22
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2021

⚠️ No Changeset found

Latest commit: 7caeebf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (d680986) and head commit (07f8a0c) are too large (479,509 characters) to display.

Please check below links to see details from the original test log.

@yuchenshi yuchenshi merged commit 03e97b8 into master Apr 15, 2021
@yuchenshi yuchenshi deleted the ys/addFrameworkForLogging branch April 15, 2021 22:11
@firebase firebase locked and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuchenshi @google-oss-bot @sam-gc