Allow FirstPartyAuth to specify a token factory func. #4773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used in lieu of direct GAPI.
|
Comment on lines
+310
to
+321
| } else { | ||
| // Make sure this really is a Gapi client. | ||
| hardAssert( | ||
| !!( | ||
| typeof this.gapi === 'object' && | ||
| this.gapi !== null && | ||
| this.gapi['auth'] && | ||
| this.gapi['auth']['getAuthHeaderValueForFirstParty'] | ||
| ), | ||
| 'unexpected gapi interface' | ||
| ); | ||
| return this.gapi['auth']['getAuthHeaderValueForFirstParty']([]); |
There was a problem hiding this comment.
Could we pass this block in as the default value for authTokenFactory()? We can then just invoke this.authTokenFactory for all callsites.
schmidt-sebastian
approved these changes
May 5, 2021
wu-hui
added a commit
that referenced
this pull request
Aug 5, 2022
* Allow FirstPartyAuth to specify a token factory func. (#4773) * Allow firstparty credentials to specify an authToken factory that is used in lieu of direct GAPI. * Remove stray import * Add return type to private method Co-authored-by: wu-hui <[email protected]> * First Party Auth Factory * More fix * Nullable gapi * Fix Co-authored-by: Richie Foreman <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
authTokenFactorytoFirstPartyCredentialsSettings, which avoids a hard dependency on GAPI.JS when specified.