Fix infinite recursion in FirebaseStorageError message getter #4760
Conversation
🦋 Changeset detectedLatest commit: 253dc67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -27,16 +27,15 @@ export class FirebaseStorageError extends FirebaseError { | |||
| */ | |||
| customData: { serverResponse: string | null } = { serverResponse: null }; | |||
|
|
|||
| private readonly baseMessage: string; | |||
| '@firebase/storage': patch | ||
| --- | ||
|
|
||
| Fix infinite recursion in FirebaseStorageError message getter |
There was a problem hiding this comment.
Is there an associated Github issue? Or an example of when the problem comes up in usage? So I can better explain to users in the release notes.
There was a problem hiding this comment.
No there isn't an existing issue (beyond this PR). Basically any time the message getter is accessed you would get a Maximum call stack size exceeded Error raised.
There was a problem hiding this comment.
Sorry, I thought the test failures were flaky and missed the actual problem. super() needs to be called with the message or else when the error is thrown it doesn't actually throw with the message. I don't think the property can be overridden with a getter. I think we should keep _baseMessage, get rid of get message(), and add some code to set serverResponse to either set this.message to _baseMessage + serverResponse or _baseMessage depending on the arg.
|
Superseded by #4807 |
This was originally broken in the refactor in #3945