Skip to content

Re-enable database@exp tests #4731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2021
Merged

Re-enable database@exp tests #4731

merged 3 commits into from
Apr 6, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@schmidt-sebastian schmidt-sebastian requested a review from jsdt as a code owner April 5, 2021 16:49
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3630d15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/database
    • @firebase/firestore

    Make sure this was intentional.

  • Package @firebase/util has a major bump which requires an additional line to bump the main "firebase" package to major.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (9fc62d3) and head commit (acbd7be).

Feiyang1
Feiyang1 approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending lint fix

@schmidt-sebastian schmidt-sebastian merged commit c417b06 into mrschmidt/argumentcount Apr 6, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/reenabletests branch April 6, 2021 00:42
@firebase firebase locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@hsubox76 hsubox76

@schmidt-sebastian schmidt-sebastian

Labels
api: database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @google-oss-bot @Feiyang1 @hsubox76