Auth explicit initialization #4714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
avolkovi,
hiranya911,
hsubox76,
sam-gc and
yuchenshi
as code owners
🦋 Changeset detectedLatest commit: 76a533d The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yuchenshi
approved these changes
Apr 2, 2021
| @@ -76,6 +80,23 @@ export function registerAuth(clientPlatform: ClientPlatform): void { | |||
| }, | |||
| ComponentType.PUBLIC | |||
| ) | |||
| /** | |||
| * Auth can only be initialized by explicitly calling getAuth() or initializeAuth() | |||
| * For why we do this, See https://docs.google.com/document/d/1vy9aI-fELpL2xlREoZt12o0JNw-JVNz4OwxYd9HcT0Y/edit?resourcekey=0-A714tRurcRonkj3lDuKVCw#heading=h.wcvc4xz0pwxf | |||
There was a problem hiding this comment.
Please create a go link for this
hsubox76
approved these changes
Apr 6, 2021
Changeset File Check
|
sam-gc
approved these changes
Apr 6, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements go/firebase-next-auth-init
Removes the need to throw an exception if, for example, firestore is initialized before Auth. Addresses #4529