Compat and @exp class for DataSnapshot #4686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
hiranya911,
hsubox76 and
jsdt
as code owners
|
schmidt-sebastian
force-pushed
the
mrschmidt/snapshot
branch
from
cc8ff0e to
a84fde9
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/snapshot
branch
from
a84fde9 to
6c80894
Compare
hsubox76
reviewed
Mar 29, 2021
| import { Reference } from './Reference'; | ||
| import { child, Reference } from './Reference'; | ||
| import { Node } from '../core/snap/Node'; | ||
| import { Index } from '../core/snap/indexes'; |
There was a problem hiding this comment.
I think this is breaking the build because I think it wants indexes/Index and I guess this shortcut works if a file is named index but I think it might be case sensitive. Didn't go through the rest of the PR yet, just wanted to put in this comment first because I think it's what's breaking the build.
There was a problem hiding this comment.
Thanks. Fixed this and the tests are passing. I can't come up with a better name for this file, otherwise I would have changed it long ago.
hsubox76
reviewed
Mar 30, 2021
Binary Size ReportAffected SDKs
Test Logs |
Size Analysis Report |
hsubox76
approved these changes
Mar 30, 2021
Feiyang1
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Add database@exp API (#4614) * Compat and @exp class for DataSnapshot (#4686) * Add events to database@exp (#4694) * Compat and @exp class for Database (#4705) * Implement Query Compat and query@exp (#4709) * Compat class for Reference (#4719) * OnDisconnect Compat (#4727) * ServerValues compat (#4728) * EnableLogging Compat (#4730) * Remove argument numbers from validation (#4729) * Update changeset * Add database@exp API docs (#4738) * Add Support for API report (#4741) * Update lets-go-travel.md * Update enableLogging
Feiyang1
added a commit
that referenced
this pull request
Apr 8, 2021
* Add database@exp API (#4614) * Compat and @exp class for DataSnapshot (#4686) * Add events to database@exp (#4694) * Compat and @exp class for Database (#4705) * Implement Query Compat and query@exp (#4709) * Compat class for Reference (#4719) * OnDisconnect Compat (#4727) * ServerValues compat (#4728) * EnableLogging Compat (#4730) * Remove argument numbers from validation (#4729) * Update changeset * Add database@exp API docs (#4738) * Add Support for API report (#4741) * pacakge database compat * export child as a public API * address comments * create database-compat dir * create overloads for database-compat * build database * add database-compat to firebase-exp * fix lint errors * include compat in build * fix typing errors * fix script name * make database types compatible * use modular instance Co-authored-by: Sebastian Schmidt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the Compat class for DataSnapshot, and also adds the
@expclass at the same time (mostly by moving code).There are a bunch of seemingly unrelated changes, but most of them are meant to remove internal references to the old legacy DataSnapshot from
/core.The next step would be to do this same change for Reference, since I only converted the code paths that I needed for the conversion.
One extra thing: The current SDK accepts numbers and string in some places for child keys, but this is not documented. I dropped accepting numbers for now.