Skip to content

Reduce FM Integration Test Impact & Run Time #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Mar 24, 2021

Context:

  • The FM integration test (IT) is flaky.
  • In a workflow, when the IT fails, the workflow normally reports the failure after 50minutes (among 10 minutes are FM IT tests).
  • It's too slow to see it fails and rerun.

Goal:

  • Make the test flow fail more quickly if it fails.
  • Reduce testing time.

This PR:

  • Refactors the test suites: separate foreground and background receive checks.
  • Make background receive check run last so if the faster test fail, the entire IT fails more quickly.
  • From reports get and delete token fails most often for unknown reason, make this test run first for the same reason above.
  • Reduce retries from 3 to 2. Retries doesn't seem to help with the majority flakiness issues.

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2021

⚠️ No Changeset found

Latest commit: c1877d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zwu52 zwu52 requested a review from hsubox76 March 24, 2021 21:17
@zwu52 zwu52 changed the title Reduce FM Integration Test Impact Reduce FM Integration Test Impact & Run Time Mar 24, 2021
@zwu52 zwu52 requested a review from Feiyang1 March 24, 2021 21:27
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 24, 2021

Size Analysis Report

Affected Products

No changes between base commit (05f5bf3) and head commit (553494f).

@zwu52 zwu52 merged commit 9323e9a into master Mar 30, 2021
@zwu52 zwu52 deleted the reduce_retry_time branch March 30, 2021 21:58
@firebase firebase locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants