Skip to content

Require _delegate in compat classes #4662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 30, 2021
Merged

Require _delegate in compat classes #4662

merged 11 commits into from
Mar 30, 2021

Conversation

hsubox76
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 54c4692

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 changed the title WIP: Require _delegate in compat _FirebaseService WIP: Require _delegate in compat classes Mar 23, 2021
@Feiyang1 Feiyang1 changed the title WIP: Require _delegate in compat classes Require _delegate in compat classes Mar 24, 2021
sam-gc
sam-gc reviewed Mar 24, 2021
View reviewed changes
packages-exp/auth-compat-exp/src/phone_auth_provider.ts
// The implementation matches but the types are subtly incompatible
// eslint-disable-next-line @typescript-eslint/no-explicit-any
phoneInfoOptions as any,
unwrap(applicationVerifier)
applicationVerifier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a type error since we haven't updated the signatures yet?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get any error. I think they might be duck type compatible.

sam-gc
sam-gc approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Auth

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 30, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (7b585e8) and head commit (847aa44).

@hsubox76 hsubox76 merged commit 72b1096 into master Mar 30, 2021
@hsubox76 hsubox76 deleted the ch-delegate branch March 30, 2021 19:52
@firebase firebase locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

@sam-gc sam-gc

@schmidt-sebastian schmidt-sebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hsubox76 @google-oss-bot @sam-gc @Feiyang1 @schmidt-sebastian