Skip to content

Fix tab sync and add tests. #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 25, 2021
Merged

Fix tab sync and add tests. #4660

merged 6 commits into from
Mar 25, 2021

Conversation

yuchenshi
Copy link
Member

WIP WIP

Tests are not passing and I have no idea why

@yuchenshi yuchenshi requested a review from sam-gc March 19, 2021 21:53
@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 13c281f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sam-gc
sam-gc reviewed Mar 19, 2021
View reviewed changes
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 19, 2021 •
edited
Loading

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • getAuth

      Size Table

      TypeBase (05f5bf3)Head (b384a07)Diff
      size
      54.3 kB
      54.6 kB
      +353 B (+0.7%)
      size-with-ext-deps
      65.3 kB
      65.6 kB
      +353 B (+0.5%)

      Dependency Table

      TypeBase (05f5bf3)Head (b384a07)Diff
      functions

      <full-list-too-large-to-display>
<see-test-logs-below-for-details>


      <full-list-too-large-to-display>
<see-test-logs-below-for-details>


      + _deleteObject
- deleteObject

    • browserLocalPersistence

      Size Table

      TypeBase (05f5bf3)Head (b384a07)Diff
      size
      31.7 kB
      31.9 kB
      +229 B (+0.7%)
      size-with-ext-deps
      42.5 kB
      42.8 kB
      +229 B (+0.5%)

    • indexedDBLocalPersistence

      Size Table

      TypeBase (05f5bf3)Head (b384a07)Diff
      size
      36.1 kB
      36.2 kB
      +124 B (+0.3%)
      size-with-ext-deps
      46.9 kB
      47.0 kB
      +124 B (+0.3%)

      Dependency Table

      TypeBase (05f5bf3)Head (b384a07)Diff
      functions

      <full-list-too-large-to-display>
<see-test-logs-below-for-details>


      <full-list-too-large-to-display>
<see-test-logs-below-for-details>


      + _deleteObject
- deleteObject

@yuchenshi yuchenshi changed the title Add tests for cross-tab sync. Fix tab sync and add tests. Mar 24, 2021
@yuchenshi yuchenshi marked this pull request as ready for review March 24, 2021 21:47
@yuchenshi yuchenshi requested a review from avolkovi as a code owner March 24, 2021 21:47
@yuchenshi yuchenshi requested a review from sam-gc March 24, 2021 21:47
sam-gc
sam-gc reviewed Mar 25, 2021
View reviewed changes
sam-gc
sam-gc reviewed Mar 25, 2021
View reviewed changes
@yuchenshi yuchenshi merged commit 7b585e8 into master Mar 25, 2021
@yuchenshi yuchenshi deleted the ys/auth-exp-tab-sync branch March 25, 2021 23:26
@firebase firebase locked and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuchenshi @google-oss-bot @sam-gc