Skip to content

tree shake WriteTree and WriteTreeRef #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 17, 2021
Merged

tree shake WriteTree and WriteTreeRef #4630

merged 6 commits into from
Mar 17, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1ada8af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (ca05ad6) Head (875a306) Diff
    browser 275 kB 275 kB +529 B (+0.2%)
    esm2017 249 kB 250 kB +1.22 kB (+0.5%)
    main 277 kB 278 kB +529 B (+0.2%)
    module 275 kB 275 kB +529 B (+0.2%)

  • @firebase/database-exp

    Type Base (ca05ad6) Head (875a306) Diff
    browser 272 kB 272 kB +529 B (+0.2%)
    esm2017 246 kB 247 kB +1.22 kB (+0.5%)
    main 273 kB 274 kB +529 B (+0.2%)
    module 272 kB 272 kB +529 B (+0.2%)

  • firebase

    Type Base (ca05ad6) Head (875a306) Diff
    firebase-database.js 177 kB 175 kB -1.55 kB (-0.9%)
    firebase.js 838 kB 836 kB -1.55 kB (-0.2%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 13, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (3a465b4) and head commit (f7af296).

schmidt-sebastian
schmidt-sebastian approved these changes Mar 13, 2021
View reviewed changes
yarn.lock
@@ -1219,6 +1219,13 @@
faye-websocket "0.11.3"
tslib "^1.11.1"

"@firebase/[email protected]":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

@Feiyang1
Copy link
Member Author

Blocked by #4638

@Feiyang1 Feiyang1 merged commit 22870cd into master Mar 17, 2021
@Feiyang1 Feiyang1 deleted the fei-writetree-ref branch March 17, 2021 17:49
@firebase firebase locked and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@jsdt jsdt Awaiting requested review from jsdt

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Feiyang1 @google-oss-bot @hsubox76 @schmidt-sebastian