Skip to content

GetOptions for controlling offline behaviour #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 12, 2018
Merged

GetOptions for controlling offline behaviour #463

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
568f4f8
GetOptions for controlling offline behaviour.
rsgowman Jan 23, 2018
56b4b91
[AUTOMATED]: Prettier Code Styling
rsgowman Jan 23, 2018
3cb151d
review feedback
rsgowman Apr 5, 2018
ac63ead
Merge branch 'master' into rsgowman/get_options
rsgowman Apr 9, 2018
2c2b4d8
Fixes resulting from merging master.
rsgowman Apr 9, 2018
78610b0
Merge remote-tracking branch 'origin/master' into rsgowman/get_options
rsgowman Apr 10, 2018
e2b769a
Merge remote-tracking branch 'origin/master' into rsgowman/get_options
rsgowman Apr 11, 2018
a5f73fb
review feedback
rsgowman Apr 11, 2018
e32c840
Update changelog
rsgowman Apr 12, 2018
5a4576f
review feedback
rsgowman Apr 12, 2018
a1eb31c
period after bracket
rsgowman Apr 12, 2018
e807f00
close all the parens!
rsgowman Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
`FirestoreSettings` to `true`. Note that the current behavior
(`DocumentSnapshot`s returning JS Date objects) will be removed in a future
release. `Timestamp` supports higher precision than JS Date.
- [feature] Added ability to control whether DocumentReference.get() and
Query.get() should fetch from server only, cache only, or attempt server and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this maximally helpful (especially since there's generally no statement completion in JS and docs will probably not be updated immediately), I'd probably say:

... should fetch from server only (by passing { source: 'server' }, cache only (by passing { source: 'cache' }), or attempt ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

fall back to the cache (which was the only option previously, and is now the
default.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: period should go after paren, I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


# 0.3.6
- [fixed] Fixed a regression in the Firebase JS release 4.11.0 that could
Expand Down