Skip to content

Tree-shake ViewProcessor #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Tree-shake ViewProcessor #4628

merged 3 commits into from
Mar 12, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2021

⚠️ No Changeset found

Latest commit: 1dbb159

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 12, 2021

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (35fdb93) Head (f58383f) Diff
    browser 275 kB 275 kB +321 B (+0.1%)
    esm2017 248 kB 249 kB +855 B (+0.3%)
    main 277 kB 277 kB +321 B (+0.1%)
    module 275 kB 275 kB +321 B (+0.1%)
  • @firebase/database-exp

    Type Base (35fdb93) Head (f58383f) Diff
    browser 272 kB 272 kB +321 B (+0.1%)
    esm2017 245 kB 246 kB +855 B (+0.3%)
    main 273 kB 273 kB +321 B (+0.1%)
    module 272 kB 272 kB +321 B (+0.1%)
  • firebase

    Type Base (35fdb93) Head (f58383f) Diff
    firebase-database.js 178 kB 177 kB -998 B (-0.6%)
    firebase.js 839 kB 838 kB -998 B (-0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 12, 2021

Size Analysis Report

Affected Products

No changes between base commit (35fdb93) and head commit (f58383f).

@schmidt-sebastian schmidt-sebastian merged commit ca05ad6 into master Mar 12, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/viewprocesor branch March 12, 2021 23:25
@firebase firebase locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants