Skip to content

Update auth compat to be properly typed in typescript #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 12, 2021
Merged

Update auth compat to be properly typed in typescript #4626

merged 4 commits into from
Mar 12, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 12, 2021

No description provided.

@sam-gc sam-gc requested a review from Feiyang1 March 12, 2021 20:43
@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: d6cf26a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 12, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (b6a7a59) and head commit (a235193).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 12, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (b6a7a59) and head commit (a235193).

@Feiyang1 Feiyang1 assigned sam-gc and unassigned Feiyang1 Mar 12, 2021
@sam-gc sam-gc merged commit ec6ccc7 into master Mar 12, 2021
@sam-gc sam-gc deleted the samgho/auth-compat-types branch March 12, 2021 21:40
@firebase firebase locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

@sam-gc sam-gc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @Feiyang1