Skip to content

[Auth] Update and add integration tests to bring us closer to parity with the existing tests #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2021
Merged

[Auth] Update and add integration tests to bring us closer to parity with the existing tests #4605

merged 2 commits into from
Mar 12, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 9, 2021

No description provided.

@sam-gc sam-gc requested a review from yuchenshi March 9, 2021 23:05
@sam-gc sam-gc requested a review from avolkovi as a code owner March 9, 2021 23:06
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: d86da96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 9, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (0ac48bb) and head commit (850525c).

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 9, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (0ac48bb) and head commit (850525c).

Test Logs

Base automatically changed from samgho/popup to master March 12, 2021 17:28
@sam-gc sam-gc force-pushed the samgho/integration-2 branch from 02c1f12 to d86da96 Compare March 12, 2021 17:32
@sam-gc sam-gc merged commit b6a7a59 into master Mar 12, 2021
@sam-gc sam-gc deleted the samgho/integration-2 branch March 12, 2021 19:10
yuchenshi pushed a commit that referenced this pull request Mar 12, 2021
@sam-gc
[Auth] Update and add integration tests to bring us closer to parity …
f15abbf 
…with the existing tests (#4605)

* More integration tests

* Formatting
yuchenshi pushed a commit that referenced this pull request Mar 12, 2021
@sam-gc
[Auth] Update and add integration tests to bring us closer to parity …
7d2ee38 
…with the existing tests (#4605)

* More integration tests

* Formatting
@firebase firebase locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi