Skip to content

Update the phone tests to work with the emulator #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 3, 2021
Merged

Update the phone tests to work with the emulator #4574

merged 8 commits into from
Mar 3, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 2, 2021

This change introduces a new mechanism for detecting emulation and then pulling the OTP from the emulator API

@sam-gc sam-gc requested a review from yuchenshi March 2, 2021 20:56
@sam-gc sam-gc requested a review from avolkovi as a code owner March 2, 2021 20:56
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2021

⚠️ No Changeset found

Latest commit: fc465e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (60040c7) and head commit (c5b71c3).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (60040c7) and head commit (c5b71c3).

yuchenshi
yuchenshi approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from samgho/more-tests to master March 3, 2021 01:03
@sam-gc sam-gc merged commit 14fbc8e into master Mar 3, 2021
@sam-gc sam-gc deleted the samgho/emulator-phone branch March 3, 2021 01:07
@firebase firebase locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi