Skip to content

Fix postBody parameter for Auth sign in #4571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

Fix postBody parameter for Auth sign in #4571

merged 2 commits into from
Mar 2, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Mar 2, 2021

We had typed it as string|null where it should actually be omitted if it's not set.

@sam-gc sam-gc requested a review from yuchenshi March 2, 2021 18:48
@sam-gc sam-gc requested a review from avolkovi as a code owner March 2, 2021 18:48
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2021

⚠️ No Changeset found

Latest commit: 3188a4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (4cbff18) and head commit (71c04bf).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • FacebookAuthProvider

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      32.0 kB
      32.0 kB
      -14 B (-0.0%)
      size-with-ext-deps
      42.8 kB
      42.8 kB
      -14 B (-0.0%)

    • GithubAuthProvider

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      32.0 kB
      32.0 kB
      -14 B (-0.0%)
      size-with-ext-deps
      42.8 kB
      42.8 kB
      -14 B (-0.0%)

    • GoogleAuthProvider

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      32.0 kB
      32.0 kB
      -14 B (-0.0%)
      size-with-ext-deps
      42.8 kB
      42.8 kB
      -14 B (-0.0%)

    • OAuthCredential

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      30.1 kB
      30.1 kB
      -14 B (-0.0%)
      size-with-ext-deps
      40.9 kB
      40.9 kB
      -14 B (-0.0%)

    • OAuthProvider

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      31.4 kB
      31.4 kB
      -14 B (-0.0%)
      size-with-ext-deps
      42.2 kB
      42.1 kB
      -14 B (-0.0%)

    • TwitterAuthProvider

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      32.0 kB
      32.0 kB
      -14 B (-0.0%)
      size-with-ext-deps
      42.8 kB
      42.8 kB
      -14 B (-0.0%)

    • getAuth

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      56.2 kB
      56.1 kB
      -20 B (-0.0%)
      size-with-ext-deps
      67.2 kB
      67.2 kB
      -20 B (-0.0%)

    • getRedirectResult

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      34.0 kB
      34.0 kB
      -6 B (-0.0%)
      size-with-ext-deps
      44.8 kB
      44.8 kB
      -6 B (-0.0%)

    • linkWithPopup

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      37.2 kB
      37.2 kB
      -20 B (-0.1%)
      size-with-ext-deps
      48.0 kB
      48.0 kB
      -20 B (-0.0%)

    • linkWithRedirect

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      32.4 kB
      32.4 kB
      -14 B (-0.0%)
      size-with-ext-deps
      43.2 kB
      43.2 kB
      -14 B (-0.0%)

    • reauthenticateWithPopup

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      37.2 kB
      37.2 kB
      -20 B (-0.1%)
      size-with-ext-deps
      48.0 kB
      48.0 kB
      -20 B (-0.0%)

    • reauthenticateWithRedirect

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      32.1 kB
      32.1 kB
      -14 B (-0.0%)
      size-with-ext-deps
      42.9 kB
      42.9 kB
      -14 B (-0.0%)

    • signInWithPopup

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      37.2 kB
      37.2 kB
      -20 B (-0.1%)
      size-with-ext-deps
      48.0 kB
      48.0 kB
      -20 B (-0.0%)

    • signInWithRedirect

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      31.9 kB
      31.9 kB
      -14 B (-0.0%)
      size-with-ext-deps
      42.7 kB
      42.6 kB
      -14 B (-0.0%)

    • browserPopupRedirectResolver

      Size Table

      TypeBase (4cbff18)Head (71c04bf)Diff
      size
      45.9 kB
      45.9 kB
      -20 B (-0.0%)
      size-with-ext-deps
      56.8 kB
      56.8 kB
      -20 B (-0.0%)

@yuchenshi yuchenshi merged commit 79dafb8 into master Mar 2, 2021
@yuchenshi yuchenshi deleted the samgho/postBody branch March 2, 2021 19:19
This was referenced Mar 5, 2021
Merged
Closed
Closed
Merged
Closed
@firebase firebase locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi