Skip to content

[Auth] set key in storage before redirect, check this key before checking for redirect events #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 1, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 26, 2021

This change prevents checking for redirects unless a key is set in storage. This brings the new SDK closer in line with the old SDK.

This change also similarly adds a new field to the resolver called _shouldInitProactively. This field is true for specific environments where opening the iframe is costly or can break the popup flow (i.e. Safari).

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2021

⚠️ No Changeset found

Latest commit: d5e81dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/util

    Type Base (fefb640) Head (4c4dfa4) Diff
    browser 20.2 kB 20.5 kB +285 B (+1.4%)
    esm2017 19.0 kB 19.2 kB +275 B (+1.4%)
    main 24.4 kB 24.8 kB +393 B (+1.6%)
    module 20.2 kB 20.5 kB +285 B (+1.4%)

Test Logs

@sam-gc sam-gc merged commit 57c73a0 into master Mar 1, 2021
@sam-gc sam-gc deleted the samgho/redirect-storage branch March 1, 2021 18:53
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (fefb640) and head commit (4c4dfa4) are too large (68,780 characters) to display.

Please check below links to see details from the original test log.

@firebase firebase locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants