Skip to content

Add Cordova support to the compatibility layer #4535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 25, 2021
Merged

Add Cordova support to the compatibility layer #4535

merged 5 commits into from
Feb 25, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 25, 2021

This change adds Cordova support to the compat package by dynamically choosing which resolver to use at runtime. In order to get this to work, I had to change the Cordova plugin types to be declared as an interface extending Window instead of passive declare namespace. Honestly this is probably for the better because that's broken like half the time

@sam-gc sam-gc requested a review from yuchenshi February 25, 2021 20:29
@sam-gc sam-gc requested a review from avolkovi as a code owner February 25, 2021 20:29
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (d4ba8da) and head commit (e2c5fe1).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 25, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (d4ba8da) and head commit (e2c5fe1).

@sam-gc sam-gc merged commit 3862071 into master Feb 25, 2021
@sam-gc sam-gc deleted the samgho/compat-popup-redirect branch February 25, 2021 21:42
@firebase firebase locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi