Skip to content

Fix the OAuth credential logic, and add support for OIDC #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2021
Merged

Fix the OAuth credential logic, and add support for OIDC #4512

merged 3 commits into from
Feb 24, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Feb 23, 2021

The OIDC stuff was pretty much there already, but the type for several things internally needed to be changed from strictly ProviderId to ProviderId | string as OIDC provider IDs are arbitrary strings

@sam-gc sam-gc requested a review from yuchenshi February 23, 2021 19:59
@sam-gc sam-gc requested a review from avolkovi as a code owner February 23, 2021 19:59
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 23, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (39a8be6) and head commit (a161b03).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • FacebookAuthProvider

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      31.8 kB
      31.8 kB
      +76 B (+0.2%)
      size-with-ext-deps
      42.5 kB
      42.6 kB
      +76 B (+0.2%)

    • GithubAuthProvider

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      31.8 kB
      31.8 kB
      +76 B (+0.2%)
      size-with-ext-deps
      42.5 kB
      42.6 kB
      +76 B (+0.2%)

    • GoogleAuthProvider

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      31.8 kB
      31.9 kB
      +76 B (+0.2%)
      size-with-ext-deps
      42.5 kB
      42.6 kB
      +76 B (+0.2%)

    • OAuthProvider

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      31.2 kB
      31.2 kB
      +76 B (+0.2%)
      size-with-ext-deps
      41.9 kB
      41.9 kB
      +76 B (+0.2%)

    • TwitterAuthProvider

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      31.8 kB
      31.9 kB
      +76 B (+0.2%)
      size-with-ext-deps
      42.5 kB
      42.6 kB
      +76 B (+0.2%)

    • getAuth

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      55.6 kB
      55.7 kB
      +76 B (+0.1%)
      size-with-ext-deps
      66.6 kB
      66.7 kB
      +76 B (+0.1%)

    • linkWithPopup

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      36.9 kB
      37.0 kB
      +76 B (+0.2%)
      size-with-ext-deps
      47.6 kB
      47.7 kB
      +76 B (+0.2%)

    • linkWithRedirect

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      32.0 kB
      32.0 kB
      +76 B (+0.2%)
      size-with-ext-deps
      42.7 kB
      42.7 kB
      +76 B (+0.2%)

    • reauthenticateWithPopup

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      36.9 kB
      37.0 kB
      +76 B (+0.2%)
      size-with-ext-deps
      47.6 kB
      47.7 kB
      +76 B (+0.2%)

    • reauthenticateWithRedirect

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      31.7 kB
      31.8 kB
      +76 B (+0.2%)
      size-with-ext-deps
      42.4 kB
      42.5 kB
      +76 B (+0.2%)

    • signInWithPopup

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      36.9 kB
      37.0 kB
      +76 B (+0.2%)
      size-with-ext-deps
      47.6 kB
      47.7 kB
      +76 B (+0.2%)

    • signInWithRedirect

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      31.4 kB
      31.5 kB
      +76 B (+0.2%)
      size-with-ext-deps
      42.2 kB
      42.2 kB
      +76 B (+0.2%)

    • browserPopupRedirectResolver

      Size Table

      TypeBase (1003b8d)Head (5bbc6fa)Diff
      size
      45.3 kB
      45.4 kB
      +76 B (+0.2%)
      size-with-ext-deps
      56.2 kB
      56.2 kB
      +76 B (+0.1%)

yuchenshi
yuchenshi approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

I remember doing a similar ProviderId | string change for Auth Emulator as well. 😸

@sam-gc sam-gc merged commit 02c1761 into master Feb 24, 2021
@sam-gc sam-gc deleted the samgho/oidc branch February 24, 2021 01:46
@firebase firebase locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-gc @google-oss-bot @yuchenshi