Skip to content

Remove remote-config-types-exp #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 23, 2021
Merged

Remove remote-config-types-exp #4496

merged 5 commits into from
Feb 23, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: b83235e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 19, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (145c62b) and head commit (c345fc1).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 19, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (145c62b) and head commit (c345fc1).

hsubox76
hsubox76 approved these changes Feb 22, 2021
View reviewed changes
packages-exp/remote-config-compat/src/remoteConfig.test.ts
@@ -21,7 +21,6 @@ import { stub } from 'sinon';
import { RemoteConfigCompatImpl } from './remoteConfig';
import { getFakeApp, getFakeModularRemoteConfig } from '../test/util';
import * as modularApi from '@firebase/remote-config-exp';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't in the scope of the PR but this isn't a potential tree-shaking problem is it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a test, so no tree-shaking concerns. It's imported this way to allow stubbing.

@Feiyang1 Feiyang1 merged commit 08e2aa3 into master Feb 23, 2021
@Feiyang1 Feiyang1 deleted the fei-rm-rc-types branch February 23, 2021 20:49
@firebase firebase locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@avolkovi avolkovi Awaiting requested review from avolkovi

@sam-gc sam-gc Awaiting requested review from sam-gc

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

@erikeldridge erikeldridge

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Feiyang1 @google-oss-bot @hsubox76 @erikeldridge