Skip to content

Update proto location #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Update proto location #4490

merged 2 commits into from
Feb 19, 2021

Conversation

thebrianchen
Copy link

Fixes #4480.

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2021

⚠️ No Changeset found

Latest commit: b011ea6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 19, 2021

Binary Size Report

Affected SDKs

  • @firebase/firestore-exp

    Type Base (483567a) Head (aa41d0d) Diff
    main 505 kB 505 kB -3 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 19, 2021

Size Analysis Report

Affected Products

No changes between base commit (483567a) and head commit (aa41d0d).

Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please merge with master to pass the lint test?

@Feiyang1 Feiyang1 assigned thebrianchen and unassigned Feiyang1 Feb 19, 2021
@thebrianchen thebrianchen merged commit a8300c1 into master Feb 19, 2021
@thebrianchen thebrianchen deleted the bc/proto-oc branch February 19, 2021 19:48
@firebase firebase locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore looks at wrong locations for proto files when running in Node.
3 participants